Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain how namespace parameter works for allocations #2090

Closed
roberthbailey opened this issue May 3, 2021 · 3 comments · Fixed by #2257
Closed

Explain how namespace parameter works for allocations #2090

roberthbailey opened this issue May 3, 2021 · 3 comments · Fixed by #2257
Assignees
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/documentation Documentation for Agones kind/feature New features for Agones
Milestone

Comments

@roberthbailey
Copy link
Member

Is your feature request related to a problem? Please describe.
It isn't clear to me what setting that namespace field in a GameServerAllocation means.

Describe the solution you'd like
I don't see a reference to namespace in https://agones.dev/site/docs/reference/gameserverallocation/ or https://agones.dev/site/docs/guides/gameserver-lifecycle/.

But it is alluded to in https://agones.dev/site/docs/getting-started/create-fleet/ and also https://agones.dev/site/docs/advanced/multi-cluster-allocation/.

This feel like an area where our docs could be better.

Describe alternatives you've considered
n/a

/cc @pooneh-m

@roberthbailey roberthbailey added the kind/feature New features for Agones label May 3, 2021
@roberthbailey
Copy link
Member Author

@pooneh-m said:

The GameServerAllocation has a namespace field as part of ObjectMeta. If not set, it defaults to "default" namespace. Agones attempts to allocate from the specified or default namespace, but not all the namespaces.

I thought that Agones might try to allocate from all namespaces (or at least all namespaces it was configured to manage via the helm setting) if the field was left off.

@roberthbailey roberthbailey added good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/documentation Documentation for Agones labels May 3, 2021
@markmandel
Copy link
Member

That's a fair comment. We should be explicit that a GameServerAllocation only searches within the same namespace that it is created in.

@eminguyen
Copy link
Contributor

I'll be working on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/documentation Documentation for Agones kind/feature New features for Agones
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants