Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use revive instead of gometalinter #237

Closed
enocom opened this issue Jun 1, 2018 · 3 comments
Closed

Use revive instead of gometalinter #237

enocom opened this issue Jun 1, 2018 · 3 comments
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory.
Milestone

Comments

@enocom
Copy link
Contributor

enocom commented Jun 1, 2018

Although it might not offer as complete coverage, revive seems significantly faster than gometalinter with a simpler API. Switching linters might help resolve the gometalinter timeouts we've been seeing in CI.

@markmandel
Copy link
Member

Should we also explore:
https://github.com/golangci/golangci-lint/

And/or maybe move the actual work over to the hosted service they provide as well? (https://golangci.com) ?

@markmandel markmandel added the area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. label Jun 1, 2018
@enocom
Copy link
Contributor Author

enocom commented Jun 1, 2018

I think so, as the timeout failures seems to be common, and it's worth looking at alternatives, even if our linting isn't 100% the same as gometalinter.

@markmandel
Copy link
Member

markmandel commented Jun 6, 2018

Even at the 5 minute timeout - sometimes it just doesn't timeout (and continues forever), and sometimes it's still hits the deadline.

I've had to restart recent builds several times at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory.
Projects
None yet
Development

No branches or pull requests

2 participants