Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible confusion on allocator CLI flag config #2598

Closed
valentintorikian opened this issue May 26, 2022 · 0 comments · Fixed by #2599
Closed

Possible confusion on allocator CLI flag config #2598

valentintorikian opened this issue May 26, 2022 · 0 comments · Fixed by #2599
Labels
kind/cleanup Refactoring code, fixing up documentation, etc
Milestone
1.24.0

Comments

@valentintorikian
Copy link
Contributor

It seems that there was a little oversight when the allocator CLI flag parsing was implemented as it reside in cmd/allocator/metrics.go. This caused a tiny bit of confusion during a PR review here #2589 (comment).

The solution is to simply move the CLI configuration logic away from cmd/allocator/metrics.go into cmd/allocator/main.go.
@valentintorikian valentintorikian mentioned this issue May 26, 2022
Merged
@roberthbailey roberthbailey added the kind/cleanup Refactoring code, fixing up documentation, etc label May 31, 2022
@SaitejaTamma SaitejaTamma added this to the 1.24.0 milestone Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
1.24.0
Development

Successfully merging a pull request may close this issue.

Moved allocator flag parsing configuration away from metrics.go valentintorikian/agones
3 participants
@valentintorikian @roberthbailey @SaitejaTamma