Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GKE] - Should we enable image streaming everywhere? #2746

Closed
markmandel opened this issue Sep 22, 2022 · 2 comments · Fixed by #2756
Closed

[GKE] - Should we enable image streaming everywhere? #2746

markmandel opened this issue Sep 22, 2022 · 2 comments · Fixed by #2756
Assignees
@gongmax
Labels
area/operations Installation, updating, metrics etc good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/documentation Documentation for Agones kind/feature New features for Agones
Milestone
1.27.0

Comments

@markmandel
Copy link
Member

Is your feature request related to a problem? Please describe.

Suggesting that we update our installation guide for GKE, and Terraform scripts to default to using image streaming.

Describe the solution you'd like

Update everything to use the node image type of COS_CONTAINERD and enable-image-streaming on each node in the cluster.

Describe alternatives you've considered

Leave it alone, and let user work it out for themselves.

Additional context

Came up because we were talking in Slack about large image sizes, and I recommended it as best practice.
@markmandel markmandel added kind/feature New features for Agones help wanted We would love help on these issues. Please come help us! good first issue These are great first issues. If you are looking for a place to start, start here! kind/documentation Documentation for Agones area/operations Installation, updating, metrics etc labels Sep 22, 2022
@roberthbailey
Copy link
Member

Our current instructions for creating a GKE cluster creates a default node pool with COS_CONTAINERD node images - it appears to be the default. So I think we only need to add the flag to enable image streaming.

@gongmax
Copy link
Collaborator

gongmax commented Sep 29, 2022

Seconding Robert's comments, COS_CONTAINERD is the default node images since GKE version 1.19

@gongmax gongmax mentioned this issue Sep 30, 2022
Merged
@mangalpalli mangalpalli added this to the 1.27.0 milestone Oct 18, 2022
@gongmax gongmax mentioned this issue Nov 29, 2022
Closed
5 tasks
@gongmax gongmax self-assigned this Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gongmax gongmax

Labels
area/operations Installation, updating, metrics etc good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/documentation Documentation for Agones kind/feature New features for Agones
Projects
None yet
Milestone
1.27.0
Development

Successfully merging a pull request may close this issue.

Enable image streaming everywhere by default gongmax/agones
4 participants
@markmandel @roberthbailey @gongmax @mangalpalli