Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Rename "Stackdriver" to "Cloud Monitoring" #2850

Closed
markmandel opened this issue Dec 5, 2022 · 0 comments · Fixed by #2862
Closed

Docs: Rename "Stackdriver" to "Cloud Monitoring" #2850

markmandel opened this issue Dec 5, 2022 · 0 comments · Fixed by #2862
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones
Milestone
1.29.0

Comments

@markmandel
Copy link
Member

See: https://agones.dev/site/docs/guides/metrics/

It still uses "Stackdriver" in the docs, which is poor SEO for anyone looking for "Cloud Monitoring".

Suggestion:

Change the headings to "Cloud Monitoring (formerly Stackdriver)" to cover all bases - and also explain why the Helm flag to enable Cloud Monitoring is still agones.metrics.stackdriverEnabled
@markmandel markmandel added kind/documentation Documentation for Agones kind/cleanup Refactoring code, fixing up documentation, etc help wanted We would love help on these issues. Please come help us! good first issue These are great first issues. If you are looking for a place to start, start here! labels Dec 5, 2022
@junninho junninho mentioned this issue Dec 9, 2022
Merged
@Kalaiselvi84 Kalaiselvi84 added this to the 1.29.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones
Projects
None yet
Milestone
1.29.0
Development

Successfully merging a pull request may close this issue.

Update metrics documentation for Cloud Monitoring/Stackdriver junninho/agones
2 participants
@markmandel @Kalaiselvi84