Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kubernetes to 1.24 #2867

Closed
29 tasks done
roberthbailey opened this issue Dec 13, 2022 · 3 comments · Fixed by #2895
Closed
29 tasks done

Update Kubernetes to 1.24 #2867

roberthbailey opened this issue Dec 13, 2022 · 3 comments · Fixed by #2895
Assignees
Labels
kind/breaking Breaking change
Milestone

Comments

@roberthbailey
Copy link
Member

roberthbailey commented Dec 13, 2022

As discussed during last week's community meeting, it's time to upgrade to the next version of Kubernetes!

List of items to do for upgrading to 1.24:

  • Update terraform submodules
    • GKE
    • Azure
    • EKS
  • Update prow cluster (even though we aren't using it yet, we should keep it in sync)
    • Recreate cluster with new scripts: cd build/terraform/prow; terraform apply -var project=agones-images
  • Update e2e cluster
    • Recreate cluster with new scripts: cd build/terraform/e2e; terraform apply -var project=agones-images
  • Update kubectl in dev tooling
    • Update kubectl in build/build-image/Dockerfile
    • Update kubectl in build/e2e-image/Dockerfile
  • Update documentation for creating clusters
    • Config.toml supported_k8s and related (do dev_ before main)
  • Update the dev tooling to create clusters
    • Minikube
    • Kind
  • Update the k8s image used in the helm pre-delete-hook
  • Update client-go
  • Update CRD API reference
    • Update links to k8s documentation in site/assets/templates/crd-doc-config.json
    • Regenerate crd api reference docs - make gen-api-docs
    • Regenerate crd client libraries - make gen-crd-client
  • Regenerate Kubernetes resource includes (e.g. ObjectMeta, PodTemplateSpec)
    • Start a cluster with make gcloud-test-cluster, uninstall agones using helm uninstall agones -n agones-system, and then run make gen-embedded-openapi and make gen-install
  • If client-go pulled in a new version of gRPC, then also
@1804devs
Copy link

I did a pull request it didn't pass im using github codespace. if anyone can help out

@roberthbailey
Copy link
Member Author

@1804devs - Thanks for your interest in this ticket and contributing to Agones!

This may not be the easiest ticket to tackle for you first contribution. Have you read the contributing guide and Developing, Testing and Building Agones? Those should help with your development workflow and help you figure out why CI isn't passing on your pull request. It is also helpful if you can run the build locally to replicate what is failing in the CI system to speed up the debugging cycle.

I would suggest trying to pick up a ticket with the "good first issue" label to make your first contribution. Those issues tend to be simpler and require a lot less understanding of the internals of the project.

@gongmax
Copy link
Collaborator

gongmax commented Jan 6, 2023

This update doesn't introduce new version of google.golang.org/grpc so there is not need to update the SDK base image grpc version and the version number in C++ Cmake scripts (steps 1 and 4 of the last task in the list above). I also run make gen-allocation-grpc and make gen-all-sdk-grp to confirmed they didn't generate any change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/breaking Breaking change
Projects
None yet
4 participants