Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreal Engine - non-ascii characters in annotations breaks websocket. #2976

Closed
tvandijck opened this issue Feb 16, 2023 · 0 comments · Fixed by #2977
Closed

Unreal Engine - non-ascii characters in annotations breaks websocket. #2976

tvandijck opened this issue Feb 16, 2023 · 0 comments · Fixed by #2977
Labels
kind/bug These are bugs.
Milestone

Comments

@tvandijck
Copy link
Contributor

What happened:

We have an annotation that looks like this:

(agones.dev/sdk-embark.squad-layout, {"maxSquads":4,"maxSquadSize":3,"allowDuplicatePlayers":true,"squadInfo":[{"playerInfo":[{"playerId":"EMBARK:8288227634772895990","playerName":"tvändijck"}],"squadSize":3}],"maxPlayers":12})

Note the playerName field has an 'ä' in it.

When calling WatchGameServer this data never arrives. HandleWatchMessage fails to correctly parse the received data, and silently ignores it without ever logging an error.

What you expected to happen:
We expect that when we call WatchGameServer we get FGameServerResponse's with those annotations.

How to reproduce it (as minimally and precisely as possible):
Put any non-standard ascii character in any json field of annotations or metadata.

@tvandijck tvandijck added the kind/bug These are bugs. label Feb 16, 2023
@Kalaiselvi84 Kalaiselvi84 added this to the 1.30.0 milestone Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug These are bugs.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants