Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed API of joonix/log #3341

Closed
jonsch318 opened this issue Aug 22, 2023 · 0 comments · Fixed by #3342
Closed

Changed API of joonix/log #3341

jonsch318 opened this issue Aug 22, 2023 · 0 comments · Fixed by #3342
Labels
kind/bug These are bugs.

Comments

@jonsch318
Copy link
Contributor

What happened:

when running go build with a project that uses agones 1.34.0 with a newer verison of joonix/log. It uses joonix.FluentdFormatter in pkg/util/runtime/runtime which changed now to joonix.NewFormatter() resulting in the following compilation error:

# agones.dev/agones/pkg/util/runtime
../../go/pkg/mod/agones.dev/agones@v1.34.0/pkg/util/runtime/runtime.go:39:30: undefined: joonix.FluentdFormatter

What you expected to happen:

building successfully.

How to reproduce it (as minimally and precisely as possible):

use i think any agenes project with the go agones and run go get -u ./... or just update the joonix/log package.

Anything else we need to know?:

Of course building works when using the specified version of joonix/log in the go.mod go mod edit -require github.com/joonix/log@v0.0.0-20180502111528-d2d3f2f4a806

Environment:

  • Agones version: 1.34.0
  • Kubernetes version (use kubectl version): none
  • Cloud provider or hardware configuration: none
  • Install method (yaml/helm): none/golang go get agones.dev/agones
  • Troubleshooting guide log(s):
  • Others:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug These are bugs.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant