Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to automatically cleanup the delete-agones-resources jobs after completion #3432

Closed
mikeseese opened this issue Oct 16, 2023 · 0 comments · Fixed by #3442
Closed
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/feature New features for Agones

Comments

@mikeseese
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When uninstalling an Agones release via helm, it creates a Job to force deleting other Agones resources if agones.crds.cleanupOnDelete is set to false.

Jobs, and their associated Pods, in Kubernetes inherently do not get deleted so that developers can review the outcome of the job. However, as this job is fairly autonomous it ends up feeling like more clutter than value to have the pods lingering until K8s garbage collection deletes them. This is exacerbated if you are bringing Agones releases up and down multiple times during development.

Describe the solution you'd like

Implementing the TTL mechanism for finished jobs would allow these jobs to be deleted after some period of time that could be configured as a chart value.

Describe alternatives you've considered

Users could create their own tooling/scripts to manually delete the jobs, or they could set agones.crds.cleanupOnDelete=false, but it would be ideal if Agones provided an interface to handle deleting completed jobs.

Additional context

Slack conversation here

@mikeseese mikeseese added the kind/feature New features for Agones label Oct 16, 2023
@markmandel markmandel added help wanted We would love help on these issues. Please come help us! good first issue These are great first issues. If you are looking for a place to start, start here! labels Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/feature New features for Agones
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants