Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ SDK no destructor body #366

Closed
nikibobi opened this issue Sep 25, 2018 · 1 comment · Fixed by #369
Closed

C++ SDK no destructor body #366

nikibobi opened this issue Sep 25, 2018 · 1 comment · Fixed by #369
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc
Milestone

Comments

@nikibobi
Copy link
Contributor

For some time now I got weird linker errors when I try to delete pointer to agones::SDK. When I looked at the source I saw that there is a destructor declared in the .h file, but it is missing in the .cpp file.

There are a few ways to fix it:

  1. Delete the declaration in the header file: ~SDK();
  2. Add empty body in cpp file: agones::SDK::~SDK() { }
  3. Set it equal to default in the header file: ~SDK() = default;
@markmandel
Copy link
Member

Please submit a PR! My c++ is not good, as you can see!

@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. labels Oct 8, 2018
@markmandel markmandel added this to the 0.5.0 milestone Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants