Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write a guide for setting up Agones with taints and tolerations #491

Closed
markmandel opened this issue Jan 17, 2019 · 7 comments · Fixed by #882
Closed

Write a guide for setting up Agones with taints and tolerations #491

markmandel opened this issue Jan 17, 2019 · 7 comments · Fixed by #882
Assignees
Labels
kind/documentation Documentation for Agones
Milestone

Comments

@markmandel
Copy link
Member

We should write a guide for setting up Agones with taints and toleration, so that Agones (and likely prom + grafana, if you are running them) are on their own machine(s), and gameservers run on their on machines -- and never the two shall meet.

This is how people should run it in production, so we should make it easy with a tool.

Stretch Goal: Make our build tooling do this by default on GKE.

@markmandel markmandel added the kind/documentation Documentation for Agones label Jan 17, 2019
@markmandel markmandel changed the title Write a guide for setting up Agoens with taints and tolerations Write a guide for setting up Agones with taints and tolerations Jan 18, 2019
@markmandel
Copy link
Member Author

Flip side - our build tooling already does this, and it's part of our helm template. But we just need to write the documentation.

@jkowalski I've never played with this stuff, from memory, you did this work, yes?

@markmandel markmandel added this to the 0.10.0 milestone Apr 3, 2019
@markmandel
Copy link
Member Author

We have this section here:
https://agones.dev/site/docs/installation/helm/#installing-the-chart

Does that mean we can close this ticket?

@jkowalski you wrote this section - wdyt?

@markmandel markmandel modified the milestones: 0.10.0, 0.11.0 May 7, 2019
@markmandel markmandel modified the milestones: 0.11.0, 0.10.0 May 16, 2019
@markmandel
Copy link
Member Author

Closing this now. We can reopen / create a new ticket if this comes up again.

@markmandel markmandel modified the milestones: 0.11.0, 0.12.0 Jun 18, 2019
@markmandel
Copy link
Member Author

Actually, looks like i didn't hit the close button. But it seems like we should move the taints and tolerations docs from here here in the helm command into a central place like installation maybe?

@roberthbailey
Copy link
Member

I've moved the instructions to the installation page along with the example of how to do it on a GKE cluster. I don't have an easy way to test EKS / AKS and the directions don't apply to minikube which has only a single node.

How do folks feel about closing this (or moving it out of the 1.0 milestone)? Or if anyone can provide similar updates to configure EKS / AKS prior to the next release that'd be even better.

@markmandel
Copy link
Member Author

I was thinking about this - I think I would feel comfortable closing this, if the section

By default Agones prefers to be scheduled on nodes labeled with stable.agones.dev/agones-system=true and tolerates the node taint stable.agones.dev/agones-system=true:NoExecute. If no dedicated nodes are available, Agones will run on regular nodes, but that’s not recommended for production use.

Was hosted up in the install section (or somewhere near it) at the top, rather than buried in the GKE section.

At least then we are explaining what needs to be done for all installations, but not providing examples (yet).

WDYT?

@roberthbailey
Copy link
Member

That sounds like a great idea. I'll send a PR over to move it up and slightly reword the GKE section to close this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Documentation for Agones
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants