Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Cluster Node addition/deletion #60

Closed
markmandel opened this issue Jan 17, 2018 · 1 comment
Closed

Support Cluster Node addition/deletion #60

markmandel opened this issue Jan 17, 2018 · 1 comment
Assignees
@markmandel
Labels
kind/design Proposal discussing new features / fixes and how they should be implemented kind/feature New features for Agones
Milestone
0.3.0

Comments

@markmandel
Copy link
Member

markmandel commented Jan 17, 2018 •
edited
Loading

Need to ensure that when the Cluster is grown / shrunk, this is handled gracefully.

  • Port Allocation will need a workerqueue for node deletion, in case the master goes down.
  • Fleets will solve the issue with non-allocatable gameservers due to port exhaustion/issues. They will be marked as Unhealthy, and then retried later.
@markmandel markmandel added kind/feature New features for Agones kind/design Proposal discussing new features / fixes and how they should be implemented labels Jan 17, 2018
@markmandel markmandel added this to the 0.2 milestone Mar 8, 2018
@markmandel markmandel modified the milestones: 0.2.0, 0.3.0 May 30, 2018
@markmandel markmandel self-assigned this Jun 15, 2018
@markmandel
Copy link
Member Author

Work here: https://github.com/markmandel/agones/tree/feature/add-remove-nodes

markmandel added a commit to markmandel/agones that referenced this issue Jun 16, 2018
@markmandel
Move cluster node addition/removal out of "experimental"
6a595f8 
Implemented workerqueue for node modifications in the
PortAllocator, so that if the master happens to go
down, then the operations the PortAllocator has to do
to keep things in check will retry and result in a
correct state.

Closes googleforgames#60
@markmandel markmandel mentioned this issue Jun 16, 2018
Merged
markmandel added a commit that referenced this issue Jun 19, 2018
@markmandel
Move cluster node addition/removal out of "experimental"
ad83f37 
Implemented workerqueue for node modifications in the
PortAllocator, so that if the master happens to go
down, then the operations the PortAllocator has to do
to keep things in check will retry and result in a
correct state.

Closes #60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markmandel markmandel

Labels
kind/design Proposal discussing new features / fixes and how they should be implemented kind/feature New features for Agones
Projects
None yet
Milestone
0.3.0
Development

No branches or pull requests
1 participant
@markmandel