Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a pull request template #608

Closed
roberthbailey opened this issue Feb 20, 2019 · 3 comments · Fixed by #1471
Closed

Create a pull request template #608

roberthbailey opened this issue Feb 20, 2019 · 3 comments · Fixed by #1471
Assignees
@thisisnotapril
Labels
area/meta Organisational matters. e.g. Governance, release cycles, etc. help wanted We would love help on these issues. Please come help us!
Milestone
1.6.0

Comments

@roberthbailey
Copy link
Member

Documentation: https://help.github.com/articles/creating-a-pull-request-template-for-your-repository/

I normally put them into .github/PULL_REQUEST_TEMPLATE.md.
@markmandel
Copy link
Member

We have a few template here: https://github.com/GoogleCloudPlatform/agones/tree/master/docs/governance/templates

Work for you?

@markmandel markmandel added the area/meta Organisational matters. e.g. Governance, release cycles, etc. label Feb 21, 2019
@thisisnotapril thisisnotapril self-assigned this Apr 5, 2019
@roberthbailey
Copy link
Member Author

I was thinking something more along the lines of what @thisisnotapril did for issues in #708. I find that having some default text (e.g. explain what the PR does, whether it fixes an issue, a release note, etc) can help people craft much nicer PR messages than just borrowing the git commit text.

@markmandel
Copy link
Member

Oh nice! Yes - this sounds great!

@roberthbailey roberthbailey mentioned this issue Jul 16, 2019
Closed
5 tasks
@markmandel markmandel added the help wanted We would love help on these issues. Please come help us! label Sep 25, 2019
@akremsa akremsa mentioned this issue Apr 14, 2020
Merged
@markmandel markmandel added this to the 1.6.0 milestone Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thisisnotapril thisisnotapril

Labels
area/meta Organisational matters. e.g. Governance, release cycles, etc. help wanted We would love help on these issues. Please come help us!
Projects
None yet
Milestone
1.6.0
Development

Successfully merging a pull request may close this issue.

Added a pull request template akremsa/agones
3 participants
@markmandel @roberthbailey @thisisnotapril