Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky Test: TestGameServerAllocationMetaDataPatch #725

Closed
markmandel opened this issue Apr 18, 2019 · 2 comments · Fixed by #726
Closed

Flaky Test: TestGameServerAllocationMetaDataPatch #725

markmandel opened this issue Apr 18, 2019 · 2 comments · Fixed by #726
Labels
area/tests Unit tests, e2e tests, anything to make sure things don't break kind/bug These are bugs.
Milestone
0.10.0

Comments

@markmandel
Copy link
Member

I've noticed that this test occasionally fails with the following result. But it only happens sometimes.

Step #12: --- FAIL: TestGameServerAllocationMetaDataPatch (23.49s)
Step #12:     gameserverallocation_test.go:131:
Step #12:               Error Trace:    gameserverallocation_test.go:131
Step #12:               Error:          Not equal:
Step #12:                               expected: "Allocated"
Step #12:                               actual  : "UnAllocated"
Step #12:
Step #12:                               Diff:
Step #12:                               --- Expected
Step #12:                               +++ Actual
Step #12:                               @@ -1,2 +1,2 @@
Step #12:                               -(v1alpha1.GameServerAllocationState) (len=9) "Allocated"
Step #12:                               +(v1alpha1.GameServerAllocationState) (len=11) "UnAllocated"
Step #12:
Step #12:               Test:           TestGameServerAllocationMetaDataPatch
Step #12:     gameserverallocation_test.go:135:
Step #12:               Error Trace:    gameserverallocation_test.go:135
Step #12:               Error:          Expected nil, but got: &errors.errorString{s:"resource name may not be empty"}
Step #12:               Test:           TestGameServerAllocationMetaDataPatch
Step #12: time="2019-04-18 15:19:40.652" level=info msg="fleet simple-fleet-lvsfg has 3/10 ready replicas"
Step #12: time="2019-04-18 15:19:40.852" level=info msg="fleet preferred-gkfqb has 112/150 ready replicas"
@markmandel markmandel added kind/bug These are bugs. area/tests Unit tests, e2e tests, anything to make sure things don't break labels Apr 18, 2019
@markmandel
Copy link
Member Author

/cc @ilkercelikyilmaz any ideas?

@markmandel
Copy link
Member Author

Oh I think I know why! I figure the cache inside the controller has yet to catch up to the state in the K8s cluster. I can probably solve this with a wait.PollImmeadiate(). On it!

@markmandel markmandel added this to the 0.10.0 milestone Apr 18, 2019
markmandel added a commit to markmandel/agones that referenced this issue Apr 18, 2019
@markmandel
Fix for flaky TestGameServerAllocationMetaDataPatch
a232f5d 
Cache eventual consistency in the controller means that this test can
be flaky. Implemented a polling request as allocatioon will work
eventually.

Closes googleforgames#725
@markmandel markmandel mentioned this issue Apr 18, 2019
Merged
markmandel added a commit to markmandel/agones that referenced this issue Apr 18, 2019
@markmandel
Fix for flaky TestGameServerAllocationMetaDataPatch
44f5fae 
Cache eventual consistency in the controller means that this test can
be flaky. Implemented a polling request as allocatioon will work
eventually.

Closes googleforgames#725
markmandel added a commit that referenced this issue Apr 23, 2019
@markmandel
Fix for flaky TestGameServerAllocationMetaDataPatch
fb0acfc 
Cache eventual consistency in the controller means that this test can
be flaky. Implemented a polling request as allocatioon will work
eventually.

Closes #725
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/tests Unit tests, e2e tests, anything to make sure things don't break kind/bug These are bugs.
Projects
None yet
Milestone
0.10.0
Development

Successfully merging a pull request may close this issue.

Fix for flaky TestGameServerAllocationMetaDataPatch markmandel/agones
1 participant
@markmandel