Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose GameServer state change metrics #831

Closed
pjayara-g opened this issue Jun 14, 2019 · 3 comments · Fixed by #1468
Closed

Expose GameServer state change metrics #831

pjayara-g opened this issue Jun 14, 2019 · 3 comments · Fixed by #1468
Labels
area/operations Installation, updating, metrics etc kind/design Proposal discussing new features / fixes and how they should be implemented kind/feature New features for Agones
Milestone

Comments

@pjayara-g
Copy link

I would like to know how long GameServers spend in a given state - for example how long does a game session last i.e. how long does it take to go from Allocated to Shutdown or how long does it take for a GameServer to become Ready. This is very helpful during deployments where a dramatic change might be a cause for concern.

I discussed this with @markmandel and we have two possible approaches:

  1. We could add code to watch events. We might be able to use ListOptions to filter it down to events about GameServers. Then the code maintains an internal cache of state -> timestamp for each game server. The cache might evict based on LRU. LRU would mostly work if we expect game servers to roughly run for the same time.
  2. Modify the GameServer CRD by adding a list of <state, timestamp> pairs to it. State updates will append to this list.
@pjayara-g pjayara-g added the kind/feature New features for Agones label Jun 14, 2019
@markmandel markmandel added the kind/design Proposal discussing new features / fixes and how they should be implemented label Jun 14, 2019
@markmandel
Copy link
Member

I expect @Kuqd might have some thoughts on this?

@pjayara-g
Copy link
Author

@roberthbailey suggested watching game servers instead of events.

@markmandel
Copy link
Member

Other thought - we are on v0.18.0 of OpenCensus. Not sure if a more up to date release would make this easier?

May be worth investigating?

@markmandel markmandel added the area/operations Installation, updating, metrics etc label Sep 4, 2019
@markmandel markmandel added this to the 1.7.0 milestone Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/operations Installation, updating, metrics etc kind/design Proposal discussing new features / fixes and how they should be implemented kind/feature New features for Agones
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants