Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to build the rust-simple example #935

Closed
roberthbailey opened this issue Jul 22, 2019 · 1 comment · Fixed by #936
Closed

Unable to build the rust-simple example #935

roberthbailey opened this issue Jul 22, 2019 · 1 comment · Fixed by #936
Labels
kind/bug These are bugs.
Milestone

Comments

@roberthbailey
Copy link
Member

What happened: Unable to build the rust-simple example.

What you expected to happen: Build completes successfully.

How to reproduce it (as minimally and precisely as possible): cd examples/rust-simple; make build-image

Anything else we need to know?: Here's the last bit of output from docker where the build fails:

Step 9/22 : COPY sdk/Cargo.toml /home/builder/agones/sdks/rust/
 ---> Using cache
 ---> bd867547e2cc
Step 10/22 : COPY sdk/Cargo.lock /home/builder/agones/sdks/rust/
COPY failed: stat /var/lib/docker/tmp/docker-builder692801886/sdk/Cargo.lock: no such file or directory
make: *** [build-image] Error 1

This may be related to #912 -- should Cargo.lock be committed into the repo?

I could probably create the file by running build before running build-image, but I don't have cargo installed on my Mac and the point of doing the build in the docker container is to have as few tools installed locally as possible.

Environment:

  • Agones version: master branch
  • Kubernetes version (use kubectl version): n/a
  • Cloud provider or hardware configuration: Mac 10.14.5
  • Install method (yaml/helm): n/a
  • Troubleshooting guide log(s):
  • Others:

/cc @aLekSer @Kuqd

@roberthbailey roberthbailey added the kind/bug These are bugs. label Jul 22, 2019
@aLekSer
Copy link
Collaborator

aLekSer commented Jul 22, 2019

I found this documentation.
It seems that we need to add Cargo.lock as we use docker with a binary https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html
Also I will prepare a fix of rust version in a rust-simple/Dockerfile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug These are bugs.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants