Centralise Controller Queue and Worker processing #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markmandel
force-pushed
the
refactor/worker-queue
branch
from
d566767
to
5c8fbd5
Compare
There were multiple places where queue and worker goroutines pattern for controllers (and related) were repeated in almost exactly the same ways. Since there are more controllers coming, it made sense to consolidate this logic into a centralised place that could be reused to make authoring them easier. This may also allow us to centralise some health checking in #98
markmandel
force-pushed
the
refactor/worker-queue
branch
from
5c8fbd5
to
1494ff2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were multiple places where queue and worker goroutines pattern for controllers (and related) were
repeated in almost exactly the same ways.
Since there are more controllers coming, it made sense to consolidate this logic into a centralised place that could be reused to make authoring them easier.
This may also allow us to centralise some health checking in #98