Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a simple-tcp game server to use for testing. #1071

Merged
merged 1 commit into from
Sep 25, 2019

Conversation

roberthbailey
Copy link
Member

No description provided.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 54c57f8a-9a92-4176-800c-2bc03e6d4809

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1071/head:pr_1071 && git checkout pr_1071
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-383ec26

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can we also add a link here:
https://agones.dev/site/docs/examples/

And then I'm happy to merge.

@markmandel markmandel added the area/examples Examples. Usually found in the `examples` directory label Sep 25, 2019
@roberthbailey
Copy link
Member Author

can we also add a link here: https://agones.dev/site/docs/examples/

Done.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 5c37bd9b-2a7e-4d76-9104-f308c2132b8a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1071/head:pr_1071 && git checkout pr_1071
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-8309bc3

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎆

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: markmandel, roberthbailey
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel merged commit 188bd12 into googleforgames:master Sep 25, 2019
@markmandel markmandel added this to the 1.1.0 milestone Sep 25, 2019
@roberthbailey roberthbailey deleted the simple-tcp-server branch August 24, 2020 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/examples Examples. Usually found in the `examples` directory lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants