Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install.yaml #1094

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Oct 2, 2019

Indentation fix of grpcPort and httpPort .

Closes #1090 .

Indentation fix
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a9ed886d-d6ab-485a-bec3-d6ad06c1f37b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1094/head:pr_1094 && git checkout pr_1094
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-55ed2bb

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 9c9be148-599c-473c-9597-99dbc33d702a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1094/head:pr_1094 && git checkout pr_1094
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-66a613d

Copy link
Contributor

@pooneh-m pooneh-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!!! :)

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aLekSer, pooneh-m
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pooneh-m pooneh-m merged commit 29fb553 into googleforgames:master Oct 2, 2019
@roberthbailey
Copy link
Member

Thanks @aLekSer!

@markmandel markmandel added this to the 1.1.0 milestone Oct 22, 2019
@markmandel markmandel added area/operations Installation, updating, metrics etc kind/bug These are bugs. labels Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/operations Installation, updating, metrics etc kind/bug These are bugs. lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

YAML installation is broken due to sdkServer validation failure
6 participants