Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metrics bug for when a gameserver is not retrievable #1101

Merged
merged 1 commit into from
Oct 4, 2019

Conversation

pooneh-m
Copy link
Contributor

@pooneh-m pooneh-m commented Oct 4, 2019

If the gameserver is not retrievable (e.g. for when a gs is allocated remotely) the operation is logged as warning and fails with nil exception as it continues to gs.Labels.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: b9a7b18d-42b9-4eb1-9374-2d78cdf4159e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1101/head:pr_1101 && git checkout pr_1101
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-e716f0d

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pooneh-m, roberthbailey
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey merged commit c5609f3 into googleforgames:master Oct 4, 2019
@markmandel markmandel added this to the 1.1.0 milestone Oct 22, 2019
@markmandel markmandel added the kind/bug These are bugs. label Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants