Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the owners file to the root of the repository. #1113

Merged
merged 1 commit into from
Oct 15, 2019
Merged

Move the owners file to the root of the repository. #1113

merged 1 commit into from
Oct 15, 2019

Conversation

roberthbailey
Copy link
Member

@roberthbailey roberthbailey commented Oct 14, 2019 •
edited
Loading

Fixes #1112

@roberthbailey
Copy link
Member Author

/assign @pooneh-m

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 22855aaf-5fa8-4f2f-852b-8a7c3d3b9fb3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

pooneh-m
pooneh-m reviewed Oct 14, 2019
View reviewed changes
OWNERS Outdated
- markmandel
- pooneh-m
- roberthbailey

emeritus_approvers:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean this group cannot approve anymore or will not be suggested as reviewer?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes (to both). See https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md#emeritus.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Does it make sense that the same set of people who their role is being changed to emeritus_approvers, approve the change or if not responding then someone else approve?

The same link says:

They are encouraged to add themselves as an "emeritus" approver under the emeritus_approvers key.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 0e276957-d0ea-4fc6-a61c-4e26efdb7be2

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1113/head:pr_1113 && git checkout pr_1113
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-7c6f23d

@pooneh-m
Copy link
Contributor

Also move Googlers to emeritus_approvers who aren't actively doing code reviews.

Can we separate the two PRs for emeritus_approvers and moving the file to root directory? I am fine with the file move, but prefer the impacted approvers to approve being moved to emeritus_approvers.

@roberthbailey
Copy link
Member Author

I removed the second commit and updated the PR text.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 6aef9383-9769-41d1-954a-48f3079bf15c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1113/head:pr_1113 && git checkout pr_1113
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-6d93533

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a4dcd6f3-3be7-480c-976b-823cc1b482a7

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1113/head:pr_1113 && git checkout pr_1113
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-be0a212

@roberthbailey roberthbailey mentioned this pull request Oct 15, 2019
Merged
@roberthbailey
Copy link
Member Author

The second commit is now a separate PR (#1116).

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pooneh-m, roberthbailey
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pooneh-m pooneh-m merged commit 3d90ca0 into googleforgames:master Oct 15, 2019
@markmandel markmandel added this to the 1.1.0 milestone Oct 22, 2019
@markmandel markmandel added area/tests Unit tests, e2e tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc labels Oct 22, 2019
@roberthbailey roberthbailey deleted the owners-file branch August 24, 2020 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pooneh-m pooneh-m pooneh-m approved these changes

Assignees

@pooneh-m pooneh-m

Labels
area/tests Unit tests, e2e tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/XS
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Please create a root OWNERS file for agones
5 participants
@roberthbailey @agones-bot @pooneh-m @google-oss-robot @markmandel