Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add owners files for the nodejs code #1119

Merged
merged 2 commits into from
Oct 28, 2019
Merged

Add owners files for the nodejs code #1119

merged 2 commits into from
Oct 28, 2019

Conversation

roberthbailey
Copy link
Member

Two reasons:

  1. To document that @steven-supersolid is handling the bulk of the code reviews (especially for style).
  2. This will cause the blunderbuss plugin for prow to auto assign code reviews.

/assign @steven-supersolid

@google-oss-robot
Copy link

@roberthbailey: GitHub didn't allow me to assign the following users: steven-supersolid.

Note that only googleforgames members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Two reasons:

  1. To document that @steven-supersolid is handling the bulk of the code reviews (especially for style).
  2. This will cause the blunderbuss plugin for prow to auto assign code reviews.

/assign @steven-supersolid

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 4825820e-8be8-4024-b8a8-e3ffd7666832

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1119/head:pr_1119 && git checkout pr_1119
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-1778607

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pooneh-m, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pooneh-m,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 947b9601-40dd-4860-815b-4e05943fac40

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1119/head:pr_1119 && git checkout pr_1119
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-d360a1d

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 38a35aee-79ef-4470-9796-61a86da0c1a1

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1119/head:pr_1119 && git checkout pr_1119
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-2b7bb65

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f1051615-72a6-407f-b927-55b2585374ed

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1119/head:pr_1119 && git checkout pr_1119
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-d34670f

@pooneh-m
Copy link
Contributor

@roberthbailey Prow has tagged this as do-not-merge/invalid-owners-file. It seems that for some reason Prow cannot verify the owner.

@roberthbailey
Copy link
Member Author

I created #1120 and assigned it to @thisisnotapril to figure out how we want to manage collaborators in this repo (and the org).

@roberthbailey roberthbailey mentioned this pull request Oct 16, 2019
Closed
@roberthbailey
Copy link
Member Author

/hold

Waiting on #1120

@markmandel
Copy link
Member

Is this still on hold?

Meta question - @steven-supersolid have you met the criteria to become a full approver?

@roberthbailey
Copy link
Member Author

/hold cancel

@steven-supersolid is now a repo collaborator so regardless of approver status this should be ok to go in now.

@roberthbailey
Copy link
Member Author

/verify-owners

@roberthbailey
Copy link
Member Author

/assign @steven-supersolid

@roberthbailey
Copy link
Member Author

boom! assignment totally works now. :)

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 97fa8760-8059-433d-8f23-58a4e29b4234

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1119/head:pr_1119 && git checkout pr_1119
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-3363f7a

@steven-supersolid
Copy link
Collaborator

Thanks for adding me! I think I meet the requirements for approver too if that is ever required but happy to just review for now

@roberthbailey
Add owners files for the nodejs code to document that @steven-supersolid
d339619 
 is

handling the bulk of the code reviews (especially for style).
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: dfa49c88-8b82-4071-8928-b5d475223e18

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey roberthbailey mentioned this pull request Oct 28, 2019
Merged
@roberthbailey
Copy link
Member Author

Build error:

includes/sdk.mk:102: recipe for target 'build-build-sdk-image' failed
The command '/bin/sh -c go get github.com/golang/protobuf/protoc-gen-go@v1.2.0 &&     go get -u golang.org/x/tools/cmd/goimports' returned a non-zero code: 1
make[4]: *** [build-build-sdk-image] Error 1
make[4]: Leaving directory '/workspace/build'
make[3]: *** [ensure-image] Error 2
includes/build-image.mk:53: recipe for target 'ensure-image' failed
includes/sdk.mk:119: recipe for target 'ensure-build-sdk-image' failed
make[2]: *** [ensure-build-sdk-image] Error 2
Unable to find image 'agones-build-sdk-go:4861e7b00a' locally
docker: Error response from daemon: pull access denied for agones-build-sdk-go, repository does not exist or may require 'docker login'.
See 'docker run --help'.
includes/sdk.mk:84: recipe for target 'run-sdk-command' failed
make[1]: *** [run-sdk-command] Error 125
includes/sdk.mk:76: recipe for target 'run-sdk-command-go' failed
make: *** [run-sdk-command-go] Error 2

Retrying to see if this was transient or is repeatable.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ad567c4f-4e4e-4731-a66c-8900b945f428

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1119/head:pr_1119 && git checkout pr_1119
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-d339619

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 79352a37-1d23-46fc-9988-a1ed95ff725a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel markmandel added the area/meta Organisational matters. e.g. Governance, release cycles, etc. label Oct 28, 2019
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 2fc4886a-a017-4535-9a30-b6d5ae887d8e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: de2addcc-f531-4795-bfa4-4795da20a27d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1119/head:pr_1119 && git checkout pr_1119
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-2447fe9

@markmandel markmandel added this to the 1.1.0 milestone Oct 28, 2019
@markmandel markmandel merged commit bc57333 into googleforgames:master Oct 28, 2019
@roberthbailey roberthbailey deleted the nodejs-owners branch August 24, 2020 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pooneh-m pooneh-m pooneh-m approved these changes

@EricFortin EricFortin Awaiting requested review from EricFortin

@ilkercelikyilmaz ilkercelikyilmaz Awaiting requested review from ilkercelikyilmaz

Assignees

@steven-supersolid steven-supersolid

@pooneh-m pooneh-m

Labels
approved area/meta Organisational matters. e.g. Governance, release cycles, etc. size/XS
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
6 participants
@roberthbailey @google-oss-robot @agones-bot @pooneh-m @markmandel @steven-supersolid