Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dynamic configuration of http port in the rust sdk #1125

Merged

Conversation

roberthbailey
Copy link
Member

@roberthbailey roberthbailey commented Oct 21, 2019

/assign @markmandel

Part of #851.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 4b1bf464-c8df-41c8-bb03-c3eb21a1806a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 5c65b12d-db90-4ed1-822c-330d64fdfda1

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1125/head:pr_1125 && git checkout pr_1125
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-e12d995

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@markmandel markmandel merged commit 82f0936 into googleforgames:master Oct 21, 2019
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel added area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/bug These are bugs. kind/feature New features for Agones and removed kind/bug These are bugs. labels Oct 21, 2019
@roberthbailey
Copy link
Member Author

@aLekSer - it just occurred to me that because of #1122 we might need to bump a number to get this into the cache for e2e tests....

@markmandel markmandel added this to the 1.1.0 milestone Oct 22, 2019
@aLekSer
Copy link
Collaborator

aLekSer commented Oct 22, 2019

Looking into this issue.
Well, we are still downloading all dependencies on the build-step:

Updating crates.io index
Downloading crates ...
Downloaded cc v1.0.46

Will fix that soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants