Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style fixes. #1129

Merged
merged 1 commit into from
Oct 22, 2019
Merged

Style fixes. #1129

merged 1 commit into from
Oct 22, 2019

Conversation

roberthbailey
Copy link
Member

Address code review comments from #1128.

/assign @steven-supersolid

@google-oss-robot
Copy link

@roberthbailey: GitHub didn't allow me to assign the following users: steven-supersolid.

Note that only googleforgames members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Address code review comments from #1128.

/assign @steven-supersolid

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 41cca753-021b-47d3-92c9-8af7c148016e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1129/head:pr_1129 && git checkout pr_1129
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-ae72126

Copy link
Collaborator

@steven-supersolid steven-supersolid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@google-oss-robot
Copy link

@steven-supersolid: changing LGTM is restricted to collaborators

In response to this:

LGTM!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 8b699f6c-2170-4784-9754-b7b3869b6713

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1129/head:pr_1129 && git checkout pr_1129
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-e819513

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey, steven-supersolid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel merged commit 08e1ee8 into googleforgames:master Oct 22, 2019
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Oct 22, 2019
@markmandel markmandel added this to the 1.1.0 milestone Oct 22, 2019
@roberthbailey roberthbailey deleted the nodejs-sdk branch August 24, 2020 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants