Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace > quoted text with alert shortcodes #1152

Merged
merged 1 commit into from
Oct 28, 2019
Merged

Replace > quoted text with alert shortcodes #1152

merged 1 commit into from
Oct 28, 2019

Conversation

markmandel
Copy link
Member

Now that we've updates docsy, we can use the alert shortcodes for notes, tips and warnings - because they are prettier, and easier to see.

@markmandel
Replace > quoted text with alert shortcodes
cec8351 
Now that we've updates docsy, we can use the alert shortcodes for
notes, tips and warnings - because they are prettier, and easier to see.
@markmandel markmandel added kind/documentation Documentation for Agones kind/cleanup Refactoring code, fixing up documentation, etc labels Oct 26, 2019
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: d6ee93a9-fa97-43e2-a56c-0e7b0970554c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1152/head:pr_1152 && git checkout pr_1152
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-cec8351

roberthbailey
roberthbailey approved these changes Oct 28, 2019
View reviewed changes
Copy link
Member

@roberthbailey roberthbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really nice!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel merged commit df0b163 into googleforgames:master Oct 28, 2019
@markmandel markmandel deleted the docs/alert-boxes branch October 28, 2019 18:55
@markmandel markmandel added this to the 1.1.0 milestone Oct 28, 2019
@roberthbailey roberthbailey mentioned this pull request Nov 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@joeholley joeholley Awaiting requested review from joeholley

@pooneh-m pooneh-m Awaiting requested review from pooneh-m

Assignees

@roberthbailey roberthbailey

Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones lgtm size/L
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @agones-bot @google-oss-robot @roberthbailey