Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broke Allocator Status in Grafana Dashboard #1158

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Broke Allocator Status in Grafana Dashboard #1158

merged 1 commit into from
Oct 29, 2019

Conversation

markmandel
Copy link
Member

When I renamed the Allocator services, I broke the dashboard components that were referencing things by their old name.

Version set grafana in Makefile because of helm/charts#18215

@markmandel
Broke Allocator Status in Grafana Dashboard
7d5bacf 
When I renamed the Allocator services, I broke the dashboard
components that were referencing things by their old name.

In Makefile, I version set grafana because of helm/charts#18215
@markmandel markmandel added kind/bug These are bugs. area/operations Installation, updating, metrics etc labels Oct 28, 2019
markmandel
markmandel commented Oct 28, 2019
View reviewed changes
build/grafana/dashboard-status.yaml
@@ -1309,111 +1321,13 @@ data:
],
"repeat": null,
"repeatDirection": "h",
"repeatIteration": 1563127715245,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cyriltovena everything seems fine, but any idea why this gets deleted?

I think it might be repeated in the previous version?

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 7d558e48-d306-41b8-be52-4bd35c7c9959

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

cyriltovena
cyriltovena approved these changes Oct 29, 2019
View reviewed changes
Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. LGTM

Should be fine

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cyriltovena, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cyriltovena,markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 47019ec6-9d74-4db1-9f9b-27e084c8f1b0

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1158/head:pr_1158 && git checkout pr_1158
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-7d5bacf

@markmandel markmandel merged commit aa91a25 into googleforgames:master Oct 29, 2019
@markmandel markmandel deleted the bug/agones-status-dash branch October 29, 2019 00:19
@markmandel markmandel added this to the 1.1.0 milestone Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

@EricFortin EricFortin Awaiting requested review from EricFortin

Assignees

@cyriltovena cyriltovena

Labels
approved area/operations Installation, updating, metrics etc kind/bug These are bugs. lgtm size/L
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @agones-bot @google-oss-robot @cyriltovena