Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra debugging for TestGameServerRestartBeforeReadyCrash #1172

Merged
merged 1 commit into from
Nov 4, 2019

Conversation

markmandel
Copy link
Member

Had an odd flakiness in:
https://console.cloud.google.com/cloud-build/builds/ac3ac819-075e-4233-bed6-926555391acd;step=21?project=agones-images

Wherein the GameServer appears to have moved straight to Unhealthy before it was Ready - which shouldn't happen, and I can't see a valid reason why.

Adding some more debugging, to give more insight in case it happens again.

Had an odd flakiness in:
https://console.cloud.google.com/cloud-build/builds/ac3ac819-075e-4233-bed6-926555391acd;step=21?project=agones-images

Wherein the GameServer appears to have moved straight to Unhealthy before
it was Ready - which shouldn't happen, and I can't see a valid reason
why.

Adding some more debugging, to give more insight in case it happens
again.
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/tests Unit tests, e2e tests, anything to make sure things don't break labels Nov 4, 2019
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 61e0f810-53e5-44e6-add3-b775f789a8d0

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1172/head:pr_1172 && git checkout pr_1172
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-6df51a0

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey merged commit 8601210 into googleforgames:master Nov 4, 2019
@markmandel markmandel deleted the cleanup/e2e-crash branch November 4, 2019 21:46
@markmandel markmandel added this to the 1.2.0 milestone Nov 4, 2019
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
…ames#1172)

Had an odd flakiness in:
https://console.cloud.google.com/cloud-build/builds/ac3ac819-075e-4233-bed6-926555391acd;step=21?project=agones-images

Wherein the GameServer appears to have moved straight to Unhealthy before
it was Ready - which shouldn't happen, and I can't see a valid reason
why.

Adding some more debugging, to give more insight in case it happens
again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/tests Unit tests, e2e tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants