Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of Unity SDK.Connect() #1181

Merged
merged 2 commits into from
Nov 15, 2019
Merged

Implementation of Unity SDK.Connect() #1181

merged 2 commits into from
Nov 15, 2019

Conversation

markmandel
Copy link
Member

Useful async function to await when the sidecar sdk server comes up, so as to not need to retry other SDK functionality.

Part of #927

@markmandel markmandel added kind/feature New features for Agones area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Nov 7, 2019
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a0986ca9-153e-4fbd-9072-0117a4890db5

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1181/head:pr_1181 && git checkout pr_1181
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-ba75f92

@roberthbailey roberthbailey requested review from pooneh-m and removed request for roberthbailey November 7, 2019 23:59
@roberthbailey
Copy link
Member

/assign @pooneh-m

pooneh-m
pooneh-m reviewed Nov 8, 2019
View reviewed changes
sdks/unity/AgonesSdk.cs Outdated
for (var i = 0; i < 30; i++)
{
Log($"Attempting to connect...{i + 1}");
var gameServer = await GameServer();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try-catch for when GameServer throws exception to retry on the exception as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh good idea. I assume I can catch the generic Exception to catch everything?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

sdks/unity/AgonesSdk.cs Show resolved Hide resolved
@roberthbailey roberthbailey requested review from dzlier-gcp and removed request for EricFortin November 12, 2019 17:35
@markmandel
Implementation of Unity SDK.Connect()
e4ee495 
Useful async function to await when the sidecar sdk server
comes up, so as to not need to retry other SDK functionality.

Part of googleforgames#927
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, pooneh-m

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,pooneh-m]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 1a06170c-72be-469e-800c-efd85b3b3616

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c17632b7-5569-4e5f-9624-780d5036e5cf

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1181/head:pr_1181 && git checkout pr_1181
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-41761d8

@markmandel markmandel merged commit 34c2afc into googleforgames:master Nov 15, 2019
@markmandel markmandel deleted the feature/unity-sdk-connect branch November 15, 2019 00:57
@markmandel markmandel added this to the 1.2.0 milestone Dec 4, 2019
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@markmandel @ilkercelikyilmaz
Implementation of Unity SDK.Connect() (googleforgames#1181)
30bac16 
Useful async function to await when the sidecar sdk server
comes up, so as to not need to retry other SDK functionality.

Part of googleforgames#927
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pooneh-m pooneh-m pooneh-m approved these changes

@dzlier-gcp dzlier-gcp Awaiting requested review from dzlier-gcp

Assignees

@dzlier-gcp dzlier-gcp

@pooneh-m pooneh-m

Labels
approved area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones size/M
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
6 participants
@markmandel @agones-bot @roberthbailey @google-oss-robot @pooneh-m @dzlier-gcp