Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky: TestGameServerUnhealthyAfterReadyCrash #1192

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Flaky: TestGameServerUnhealthyAfterReadyCrash #1192

merged 1 commit into from
Dec 3, 2019

Conversation

markmandel
Copy link
Member

This should fix the flakiness with this test.

@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/tests Unit tests, e2e tests, anything to make sure things don't break labels Nov 20, 2019
roberthbailey
roberthbailey reviewed Nov 20, 2019
View reviewed changes
test/e2e/gameserver_test.go Outdated

// keep crashing, until we move to Unhealthy. Solves potential issues with controller Informaer cache
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'm missing something but how does this loop exit when the game server moves to unhealthy? It only terminates when there is an error writing a packet to the udp destination, which seems unrelated to the game server becoming unhealthy.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I just wanted to give it an eventual exit condition. So it will stop when there is nothing left to send things to (i.e. it errors out)

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 7f8da5ff-c75f-40d6-8328-f33bf6efb134

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1192/head:pr_1192 && git checkout pr_1192
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-e715b46

@markmandel
Flaky: TestGameServerUnhealthyAfterReadyCrash
1a9638e 
This should fix the flakiness with this test.
@markmandel markmandel force-pushed the flaky/TestGameServerUnhealthyAfterReadyCrash branch from e715b46 to 1a9638e Compare December 3, 2019 21:07
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2e8bcfd5-96c7-4067-9edf-5a2d9e605557

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1192/head:pr_1192 && git checkout pr_1192
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-1a9638e

@roberthbailey roberthbailey merged commit 08df288 into googleforgames:master Dec 3, 2019
@markmandel markmandel added this to the 1.2.0 milestone Dec 4, 2019
@markmandel markmandel deleted the flaky/TestGameServerUnhealthyAfterReadyCrash branch December 5, 2019 23:20
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@markmandel @ilkercelikyilmaz
Flaky: TestGameServerUnhealthyAfterReadyCrash (googleforgames#1192)
2f88ca4 
This should fix the flakiness with this test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@dzlier-gcp dzlier-gcp Awaiting requested review from dzlier-gcp

Assignees

@roberthbailey roberthbailey

Labels
approved area/tests Unit tests, e2e tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/S
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @agones-bot @google-oss-robot @roberthbailey