Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cleanup Agones resources script #1240

Merged
merged 2 commits into from
Dec 18, 2019
Merged

Fix cleanup Agones resources script #1240

merged 2 commits into from
Dec 18, 2019

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Dec 18, 2019

Remove old stable.agones.dev pods getter which was hiding new one.

@aLekSer
Fix cleanup agones resources script
a421e19 
Remove old stable.agones.dev pods getter which was hiding new one.
aLekSer
aLekSer commented Dec 18, 2019
View reviewed changes
install/helm/agones/scripts/delete_agones_resources.sh
# Building the list of pods we need to ensure are deleted.
gs=$(kubectl -n $ns get gs -o jsonpath='{.items[*].metadata.name}')

for g in $gs; do
pod=$(kubectl -n $ns get po -l agones.dev/gameserver=$g -o jsonpath='{.items[*].metadata.name}')
# TODO(roberthbailey): Remove this after we cut Agones 0.12.0
pod=$(kubectl -n $ns get po -l stable.agones.dev/gameserver=$g -o jsonpath='{.items[*].metadata.name}')
Copy link
Collaborator Author

@aLekSer aLekSer Dec 18, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This variable reassignment hides the pod list retrieved by a previous line. This could be the reason why previously make uninstall && make install fails on gameservers crds which not able to be deleted.

@aLekSer
Copy link
Collaborator Author

aLekSer commented Dec 18, 2019

Hello @roberthbailey , please take a look. Either we can merge this or we need to add one more pods="$pods $pod" in between.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 8bc5cdbc-d89d-4b1a-98d0-974aa44c6183

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1240/head:pr_1240 && git checkout pr_1240
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-a421e19

@aLekSer aLekSer changed the title Fix cleanup agones resources script Fix cleanup Agones resources script Dec 18, 2019
@markmandel
Copy link
Member

/assign @roberthbailey

@markmandel markmandel added area/operations Installation, updating, metrics etc kind/bug These are bugs. labels Dec 18, 2019
@markmandel
Copy link
Member

/assign @markmandel taking this for a test run now!

markmandel
markmandel approved these changes Dec 18, 2019
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed, this is working!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel added this to the 1.3.0 milestone Dec 18, 2019
@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 88f2ddbe-2d45-49eb-a827-c57a77546110

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1240/head:pr_1240 && git checkout pr_1240
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-9f8c08d

@markmandel markmandel merged commit 5eabf77 into googleforgames:master Dec 18, 2019
@roberthbailey roberthbailey removed their assignment Dec 18, 2019
@aLekSer aLekSer deleted the fix/delete-resources branch January 29, 2020 18:34
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@aLekSer @ilkercelikyilmaz
Fix cleanup agones resources script (googleforgames#1240)
862fdab 
Remove old stable.agones.dev pods getter which was hiding new one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

@EricFortin EricFortin Awaiting requested review from EricFortin

Assignees

@markmandel markmandel

Labels
approved area/operations Installation, updating, metrics etc kind/bug These are bugs. size/XS
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@aLekSer @agones-bot @markmandel @google-oss-robot @roberthbailey