Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove syncGameServerSet logging. #1241

Merged

Conversation

markmandel
Copy link
Member

I don't think it's neccessary in any scenario.

It feels like leftover debugging code, so let's remove it.

I don't think it's neccessary in any scenario.

It feels like leftover debugging code, so let's remove it.
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/operations Installation, updating, metrics etc labels Dec 18, 2019
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: f9ae73e1-73dd-4eee-aa69-af8d34ea3927

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 4dbff4bf-918a-4411-ad08-d213807a2c5b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1241/head:pr_1241 && git checkout pr_1241
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-1d57f54

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, pooneh-m

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,pooneh-m]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 5aca6f2b-853c-4b76-8308-b648f1884dc8

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1241/head:pr_1241 && git checkout pr_1241
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-f57e7e2

@markmandel markmandel merged commit 19387d2 into googleforgames:master Dec 19, 2019
@markmandel markmandel added this to the 1.3.0 milestone Dec 19, 2019
@markmandel markmandel deleted the cleanup/syncGameServerSet-logging branch December 19, 2019 00:18
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
I don't think it's neccessary in any scenario.

It feels like leftover debugging code, so let's remove it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/operations Installation, updating, metrics etc kind/cleanup Refactoring code, fixing up documentation, etc size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants