Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a minor typo in the unity example's README #1265

Merged
merged 1 commit into from
Jan 8, 2020
Merged

Fix a minor typo in the unity example's README #1265

merged 1 commit into from
Jan 8, 2020

Conversation

roberthbailey
Copy link
Member

Fixes #1259

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: b8404725-cd2c-48c7-9026-91cc5091236f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1265/head:pr_1265 && git checkout pr_1265
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-ac6dcb4

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: ff564b69-cec9-466f-b728-a927871bab5a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones labels Jan 8, 2020
@markmandel markmandel added this to the 1.3.0 milestone Jan 8, 2020
@markmandel markmandel added the area/examples Examples. Usually found in the `examples` directory label Jan 8, 2020
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: d9ba0727-9a1b-4ea6-8fb9-885889a34a56

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1265/head:pr_1265 && git checkout pr_1265
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-7398774

@markmandel markmandel merged commit 915b313 into googleforgames:master Jan 8, 2020
@roberthbailey roberthbailey deleted the unity-readme branch August 24, 2020 23:01
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@roberthbailey @ilkercelikyilmaz
Fix a minor typo in the unity example's README. (googleforgames#1265)
1756773
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@dzlier-gcp dzlier-gcp Awaiting requested review from dzlier-gcp

@pooneh-m pooneh-m Awaiting requested review from pooneh-m

Assignees

@markmandel markmandel

Labels
approved area/examples Examples. Usually found in the `examples` directory kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones lgtm size/XS
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

typo in README.md
4 participants
@roberthbailey @agones-bot @google-oss-robot @markmandel