Add Annotations validation for Template ObjectMeta #1266

aLekSer · 2020-01-09T14:21:19Z

Check key/value length and format for Annotations which belongs to Fleet, GameServerSet and
GameServerSpec.

Steps to reproduce is here: #1244 (comment)

aLekSer · 2020-01-09T14:25:46Z

Can open a separate issue if needed, but it is identical to Labels issue. Note that ValidateAnnotations() belongs to a separate import path.
Annotations Kubernetes doc for the reference.

agones-bot · 2020-01-09T14:36:57Z

Build Succeeded 👏

Build Id: ec9c9ff9-2cac-4794-b708-e640f86eea57

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.3.0-2cd7956
image: gcr.io/agones-images/agones-sdk:1.3.0-2cd7956
image: gcr.io/agones-images/agones-ping:1.3.0-2cd7956
Linux C++ SDK (build): agonessdk-1.3.0-2cd7956-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.3.0-2cd7956.zip

A preview of the website (the last 30 builds are retained):

https://2cd7956-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1266/head:pr_1266 && git checkout pr_1266
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-2cd7956

agones-bot · 2020-01-09T14:41:59Z

Build Succeeded 👏

Build Id: bacd8f2a-27b2-482d-a66d-bc36d5e76298

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.3.0-6626daf
image: gcr.io/agones-images/agones-sdk:1.3.0-6626daf
image: gcr.io/agones-images/agones-ping:1.3.0-6626daf
Linux C++ SDK (build): agonessdk-1.3.0-6626daf-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.3.0-6626daf.zip

A preview of the website (the last 30 builds are retained):

https://6626daf-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1266/head:pr_1266 && git checkout pr_1266
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-6626daf

agones-bot · 2020-01-09T14:47:31Z

Build Succeeded 👏

Build Id: 936ce7d9-984d-433e-bfea-1eba5ee3c8f6

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.3.0-68b10dc
image: gcr.io/agones-images/agones-sdk:1.3.0-68b10dc
image: gcr.io/agones-images/agones-ping:1.3.0-68b10dc
Linux C++ SDK (build): agonessdk-1.3.0-68b10dc-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.3.0-68b10dc.zip

A preview of the website (the last 30 builds are retained):

https://68b10dc-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1266/head:pr_1266 && git checkout pr_1266
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-68b10dc

markmandel · 2020-01-10T00:06:13Z

Is this ready for review? Or shall I wait until it moved out Draft?

aLekSer · 2020-01-10T07:57:30Z

I will add more tests today and move this PR into a Ready state.

agones-bot · 2020-01-10T08:45:10Z

Build Succeeded 👏

Build Id: d644862d-a81d-48e1-8ead-1df3bc0f64ee

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.3.0-40e0421
image: gcr.io/agones-images/agones-sdk:1.3.0-40e0421
image: gcr.io/agones-images/agones-ping:1.3.0-40e0421
Linux C++ SDK (build): agonessdk-1.3.0-40e0421-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.3.0-40e0421.zip

A preview of the website (the last 30 builds are retained):

https://40e0421-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1266/head:pr_1266 && git checkout pr_1266
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-40e0421

agones-bot · 2020-01-10T12:17:29Z

Build Failed 😱

Build Id: 1f028401-c49d-4905-8e12-abc8412fa114

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-01-10T14:14:18Z

Build Failed 😱

Build Id: a489e7c2-a0f5-48ce-ac8e-d741cbf6ff7f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Check value and key length for Annotations which belongs to Fleet and GameServerSpec.

agones-bot · 2020-01-10T14:31:09Z

Build Succeeded 👏

Build Id: a77a9566-733f-42ee-b7cb-12d06fe6e67f

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.3.0-6b4d5a0
image: gcr.io/agones-images/agones-sdk:1.3.0-6b4d5a0
image: gcr.io/agones-images/agones-ping:1.3.0-6b4d5a0
Linux C++ SDK (build): agonessdk-1.3.0-6b4d5a0-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.3.0-6b4d5a0.zip

A preview of the website (the last 30 builds are retained):

https://6b4d5a0-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1266/head:pr_1266 && git checkout pr_1266
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-6b4d5a0

google-oss-robot · 2020-01-11T00:07:15Z

New changes are detected. LGTM label has been removed.

google-oss-robot · 2020-01-11T00:07:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot · 2020-01-11T00:07:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

agones-bot · 2020-01-11T00:19:42Z

Build Succeeded 👏

Build Id: 46cc0be1-bfe3-49e5-8b8a-5e238abe0e29

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.3.0-9e8531d
image: gcr.io/agones-images/agones-sdk:1.3.0-9e8531d
image: gcr.io/agones-images/agones-ping:1.3.0-9e8531d
Linux C++ SDK (build): agonessdk-1.3.0-9e8531d-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.3.0-9e8531d.zip

A preview of the website (the last 30 builds are retained):

https://9e8531d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1266/head:pr_1266 && git checkout pr_1266
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-9e8531d

Check value and key length for Annotations which belongs to Fleet and GameServerSpec. Co-authored-by: Mark Mandel <mark.mandel@gmail.com>

google-oss-robot added the do-not-merge/work-in-progress label Jan 9, 2020

google-oss-robot requested review from dzlier-gcp and EricFortin January 9, 2020 14:21

google-oss-robot added the size/XXL label Jan 9, 2020

aLekSer force-pushed the validateAnnotations branch 2 times, most recently from 6626daf to 68b10dc Compare January 9, 2020 14:34

aLekSer force-pushed the validateAnnotations branch from 68b10dc to 40e0421 Compare January 10, 2020 08:32

aLekSer force-pushed the validateAnnotations branch from 40e0421 to c53811a Compare January 10, 2020 12:12

aLekSer force-pushed the validateAnnotations branch from c53811a to 6cb1cc8 Compare January 10, 2020 14:09

aLekSer marked this pull request as ready for review January 10, 2020 14:09

google-oss-robot removed the do-not-merge/work-in-progress label Jan 10, 2020

Add Annotations validation for Template ObjectMeta

6b4d5a0

Check value and key length for Annotations which belongs to Fleet and GameServerSpec.

aLekSer force-pushed the validateAnnotations branch from 6cb1cc8 to 6b4d5a0 Compare January 10, 2020 14:18

markmandel approved these changes Jan 11, 2020

View reviewed changes

google-oss-robot assigned markmandel Jan 11, 2020

google-oss-robot added the lgtm label Jan 11, 2020

Merge branch 'master' into validateAnnotations

9e8531d

google-oss-robot removed the lgtm label Jan 11, 2020

google-oss-robot added the approved label Jan 11, 2020

markmandel added area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones lgtm and removed approved labels Jan 11, 2020

google-oss-robot added the approved label Jan 11, 2020

markmandel added this to the 1.3.0 milestone Jan 11, 2020

markmandel merged commit e2132cc into googleforgames:master Jan 11, 2020

aLekSer deleted the validateAnnotations branch January 13, 2020 15:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Annotations validation for Template ObjectMeta #1266

Add Annotations validation for Template ObjectMeta #1266

aLekSer commented Jan 9, 2020

aLekSer commented Jan 9, 2020

agones-bot commented Jan 9, 2020

agones-bot commented Jan 9, 2020

agones-bot commented Jan 9, 2020

markmandel commented Jan 10, 2020

aLekSer commented Jan 10, 2020

agones-bot commented Jan 10, 2020

agones-bot commented Jan 10, 2020

agones-bot commented Jan 10, 2020

agones-bot commented Jan 10, 2020

google-oss-robot commented Jan 11, 2020

google-oss-robot commented Jan 11, 2020

google-oss-robot commented Jan 11, 2020

agones-bot commented Jan 11, 2020

Add Annotations validation for Template ObjectMeta #1266

Add Annotations validation for Template ObjectMeta #1266

Conversation

aLekSer commented Jan 9, 2020

aLekSer commented Jan 9, 2020

agones-bot commented Jan 9, 2020

agones-bot commented Jan 9, 2020

agones-bot commented Jan 9, 2020

markmandel commented Jan 10, 2020

aLekSer commented Jan 10, 2020

agones-bot commented Jan 10, 2020

agones-bot commented Jan 10, 2020

agones-bot commented Jan 10, 2020

agones-bot commented Jan 10, 2020

google-oss-robot commented Jan 11, 2020

google-oss-robot commented Jan 11, 2020

google-oss-robot commented Jan 11, 2020

agones-bot commented Jan 11, 2020