Show GameServer name in TestGameServerReserve flakiness fail #1292
Conversation
markmandel
added
the
area/tests
|
Build Succeeded 👏 Build Id: e9e7cfbb-9088-4609-94f5-fcd49c277e6f The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
test/e2e/gameserver_test.go
Outdated
|
|
||
| // it should go back after 10 seconds | ||
| gs, err = framework.WaitForGameServerState(readyGs, agonesv1.GameServerStateReady, 15*time.Second) | ||
| assert.NoError(t, err) | ||
| assert.Equal(t, agonesv1.GameServerStateReady, gs.Status.State) | ||
|
|
||
| logrus.Info("SLEEPING") | ||
| time.Sleep(time.Minute) |
There was a problem hiding this comment.
Was the sleep for local development? I don't think we want to commit that.
test/e2e/gameserver_test.go
Outdated
| @@ -491,13 +491,16 @@ func TestGameServerReserve(t *testing.T) { | |||
| assert.Equal(t, "ACK: RESERVE\n", reply) | |||
|
|
|||
| gs, err = framework.WaitForGameServerState(readyGs, agonesv1.GameServerStateReserved, time.Minute) | |||
| assert.NoError(t, err) | |||
| assert.Equal(t, agonesv1.GameServerStateReserved, gs.Status.State) | |||
| assert.NoError(t, err, readyGs.ObjectMeta.Name) | |||
There was a problem hiding this comment.
I'm not exactly sure how this prints, but something like fmt.Sprintf("ready game server name = %s", readyGs.ObjectMeta.Name) might make this easier to understand in the failure output.
Extra debugging, so we can dig into what is going wrong in this test. Work on googleforgames#1276
markmandel
force-pushed
the
flaky/TestGameServerReserve-debug
branch
from
be1edc3
to
4bc1400
Compare
|
Build Succeeded 👏 Build Id: 4a474fb4-ed49-4401-a65d-1e6c270b7eb3 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markmandel, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…orgames#1292) Extra debugging, so we can dig into what is going wrong in this test. Work on googleforgames#1276
Extra debugging, so we can dig into what is going wrong in this test.
Work on #1276