Unity SDK - Initialize in Awake() #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Awake() is more commonly used to initialize variables as it is guaranteed to run as soon as the game object is instantiated or activated. Start() is called before the first Update(), which might be up to a frame later. See Unity docs for reference https://docs.unity3d.com/ScriptReference/MonoBehaviour.Awake.html
|
Build Succeeded 👏 Build Id: c377728d-2f9f-4d3c-ad2a-3016a38ffcad The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
roberthbailey
approved these changes
Feb 12, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mollstam, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
markmandel
added
the
area/user-experience
ilkercelikyilmaz
pushed a commit
to ilkercelikyilmaz/agones
that referenced
this pull request
Oct 23, 2020
Awake() is more commonly used to initialize variables as it is guaranteed to run as soon as the game object is instantiated or activated. Start() is called before the first Update(), which might be up to a frame later. See Unity docs for reference https://docs.unity3d.com/ScriptReference/MonoBehaviour.Awake.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into an issue where
AgonesSdkwas used before it was initialized due to the fact that we keep the game object deactivated (checkbox unticked in editor) only to activate it when running as the game server. Activating the game object (thus activating the AgonesSdk MonoBehaviour) callsAwake()butStart()isn't called until "before the nextUpdate()" which might be up to a frame later.We ended up calling
WatchGameServer(...)beforesidecarAddresshas been set (inStart()) so the watch request was sent to "http://localhost/watch/gameserver" instead (since the request was created with only the path component).This PR moves the
sidecarAddressinit toAwake()so that when the MB has been "awoken" it is ready to be used. I left the health check kick-off inStart()as it felt more "internal start logic" than "init state", if that makes sense.Feedback appreciated. 🙂