Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SDK conformance GRPC gateway test #1390

Merged
merged 3 commits into from
Mar 5, 2020
Merged

Fix SDK conformance GRPC gateway test #1390

merged 3 commits into from
Mar 5, 2020

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Mar 4, 2020

Add more time to wait before start, update nodejs version to even
number.

@aLekSer
Fix SDK conformance GRPC gateway test
f974192 
Add more time to wait before start, update nodejs version to even
number.
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 3f32decf-e2e2-4664-872c-a34211f87a86

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: b03f4a0b-2a10-43d9-b419-1b33e726fa86

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1390/head:pr_1390 && git checkout pr_1390
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-4ad0e28

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel added area/tests Unit tests, e2e tests, anything to make sure things don't break kind/bug These are bugs. labels Mar 5, 2020
@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 4457435e-d504-4524-bd95-de64f3df293f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1390/head:pr_1390 && git checkout pr_1390
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-c27dfa7

@markmandel markmandel merged commit cadb925 into googleforgames:master Mar 5, 2020
@markmandel markmandel added this to the 1.5.0 milestone Mar 5, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@markmandel @ilkercelikyilmaz
Fix SDK conformance GRPC gateway test (googleforgames#1390)
30b6d34 
Add more time to wait before start, update nodejs version to even
number.

Co-authored-by: Mark Mandel <markmandel@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@EricFortin EricFortin Awaiting requested review from EricFortin

@pooneh-m pooneh-m Awaiting requested review from pooneh-m

Assignees

@roberthbailey roberthbailey

Labels
approved area/tests Unit tests, e2e tests, anything to make sure things don't break kind/bug These are bugs. size/S
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@aLekSer @agones-bot @google-oss-robot @roberthbailey @markmandel