Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch godoc.org links to pkg.go.dev #1394

Merged
merged 1 commit into from
Mar 5, 2020
Merged

Switch godoc.org links to pkg.go.dev #1394

merged 1 commit into from
Mar 5, 2020

Conversation

markmandel
Copy link
Member

pkg.go.dev is nicer - you can choose specific versions of Go APIs to browse, and the latest tag is the default - not master (you can't even see master!)

@markmandel
Switch godoc.org links to pkg.go.dev
1ff0af1 
pkg.go.dev is nicer - you can choose specific versions of Go APIs to
browse, and the latest tag is the default - not master (you can't even
see master!)
@markmandel markmandel added kind/documentation Documentation for Agones kind/cleanup Refactoring code, fixing up documentation, etc labels Mar 5, 2020
@markmandel
Copy link
Member Author

@aLekSer this should include your feedback from #1384

aLekSer
aLekSer approved these changes Mar 5, 2020
View reviewed changes
Copy link
Collaborator

@aLekSer aLekSer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I see, thanks for applying my feedback.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 32d8e74c-9f25-4f76-a41b-cd44332cc2f6

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1394/head:pr_1394 && git checkout pr_1394
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-1ff0af1

@markmandel markmandel added this to the 1.5.0 milestone Mar 5, 2020
@markmandel markmandel merged commit 5de0f9c into googleforgames:master Mar 5, 2020
@markmandel markmandel deleted the cleanup/godoc branch March 5, 2020 18:50
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@markmandel @ilkercelikyilmaz
Switch godoc.org links to pkg.go.dev (googleforgames#1394)
a5edef4 
pkg.go.dev is nicer - you can choose specific versions of Go APIs to
browse, and the latest tag is the default - not master (you can't even
see master!)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aLekSer aLekSer aLekSer approved these changes

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

@dzlier-gcp dzlier-gcp Awaiting requested review from dzlier-gcp

Assignees

@aLekSer aLekSer

Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones lgtm size/S
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @google-oss-robot @agones-bot @aLekSer