Revert local sdk logging from Debug->Info #1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I got too aggressive with moving logging to Debug, and somehow managed to pickup the local SDK. I don't think the local SDK logging should be moved to debug, as the reason the local SDK server exists is to provide information about what SDK commands are being run -- so it is an Info level debug operation,
markmandel
added
kind/bug
|
Build Succeeded 👏 Build Id: b8c4960e-9933-458d-8763-b2664fedcacd The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
roberthbailey
approved these changes
Apr 2, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markmandel, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ilkercelikyilmaz
pushed a commit
to ilkercelikyilmaz/agones
that referenced
this pull request
Oct 23, 2020
I got too aggressive with moving logging to Debug, and somehow managed to pickup the local SDK. I don't think the local SDK logging should be moved to debug, as the reason the local SDK server exists is to provide information about what SDK commands are being run -- so it is an Info level debug operation,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got too aggressive with moving logging to Debug, and somehow managed to pickup the local SDK.
I don't think the local SDK logging should be moved to debug, as the reason the local SDK server exists is to provide information about what SDK commands are being run -- so it is an Info level debug operation.
(This change happened after the last release, so it's safe to revert)