Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allocator client tutorial: add steps for MacOS #1484

Merged

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Apr 21, 2020

Minor fix of argument and summarize all environment vars together to be
used by shell script.
Tested that all steps could be performed on MacOS.

What type of PR is this?

/kind documentation

What this PR does / Why we need it:
Fixes Tutorial for MacOS.

Which issue(s) this PR fixes:

Special notes for your reviewer:
Results of running the bash script:

 ./test.sh
response: state:Allocated gameServerName:"simple-udp-phptn-6kd8m" ports:<name:"default" port:7947 > address:"35.197.45.57" nodeName:"gke-test-cluster-default-ac24bb9b-hhsl"

Minor fix of argument and summarize all environment vars together to be
used by shell script.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 94350d96-a8c3-4245-9ec2-4921d434d29d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1484/head:pr_1484 && git checkout pr_1484
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-650f80b

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, pooneh-m

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones labels Apr 21, 2020
@markmandel markmandel added this to the 1.6.0 milestone Apr 21, 2020
@markmandel markmandel merged commit b377f19 into googleforgames:master Apr 21, 2020
@aLekSer aLekSer deleted the docs/Allocator-client-tutorial branch April 21, 2020 17:44
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Minor fix of argument and summarize all environment vars together to be
used by shell script.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants