Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FeatureFlag:PlayerTesting ➡ FeatureFlag:PlayerTracking #1502

Merged
merged 1 commit into from
Apr 30, 2020
Merged

FeatureFlag:PlayerTesting ➡ FeatureFlag:PlayerTracking #1502

merged 1 commit into from
Apr 30, 2020

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

I managed to mess this up all over the place, and didn't see it until
@aLekSer pointed it out on a recent PR.

This is now fixed!

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Thanks @aLekSer !

@markmandel
FeatureFlag:PlayerTesting ➡ FeatureFlag:PlayerTracking
ec68076 
I managed to mess this up all over the place, and didn't see it until
@aLekSer pointed it out on a recent PR.

This is now fixed!
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Apr 30, 2020
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 7491f82e-6d95-4f30-9093-cfc7b6090298

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: aa6c4675-f903-438e-8138-9f66fa6f12d9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1502/head:pr_1502 && git checkout pr_1502
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-ec68076

aLekSer
aLekSer approved these changes Apr 30, 2020
View reviewed changes
Copy link
Collaborator

@aLekSer aLekSer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usual thing to misread when you know what you expect to read.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aLekSer aLekSer merged commit 3bb4e1f into googleforgames:master Apr 30, 2020
@markmandel markmandel deleted the cleanup/not-player-testing branch April 30, 2020 14:02
@markmandel markmandel added this to the 1.6.0 milestone May 19, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@markmandel @ilkercelikyilmaz
FeatureFlag:PlayerTesting ➡ FeatureFlag:PlayerTracking (googleforgame…
abdd098 
…s#1502)

I managed to mess this up all over the place, and didn't see it until
@aLekSer pointed it out on a recent PR.

This is now fixed!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aLekSer aLekSer aLekSer approved these changes

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

@dzlier-gcp dzlier-gcp Awaiting requested review from dzlier-gcp

Assignees

@aLekSer aLekSer

Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/M
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @agones-bot @google-oss-robot @aLekSer