Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix a typo in README.md #1505

Merged
merged 1 commit into from
Apr 30, 2020
Merged

fix a typo in README.md #1505

merged 1 commit into from
Apr 30, 2020

Conversation

robinbraemer
Copy link
Contributor

No description provided.

@robinbraemer
Copy link
Contributor Author

/assign @EricFortin

markmandel
markmandel approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, robinbraemer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones labels Apr 30, 2020
@markmandel markmandel added this to the 1.6.0 milestone Apr 30, 2020
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 4ba2cc82-9166-492f-a157-d293f7e7cf50

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1505/head:pr_1505 && git checkout pr_1505
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-38bbd1d

@markmandel markmandel merged commit d12ae7b into googleforgames:master Apr 30, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@robinbraemer @ilkercelikyilmaz
fix a typo in README.md (googleforgames#1505)
dbb5f53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@dzlier-gcp dzlier-gcp Awaiting requested review from dzlier-gcp

Assignees

@markmandel markmandel

@EricFortin EricFortin

Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones lgtm size/XS
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@robinbraemer @google-oss-robot @agones-bot @markmandel @EricFortin