Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tolerations for delete hook script #1521

Merged
merged 2 commits into from
May 7, 2020

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented May 7, 2020

Tolerations for delete Agones resources same as for the controller.

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature

/kind hotfix

What this PR does / Why we need it:
Currently Job for deleting resources created on default node pool. If we add taints to all nodes in default node pool, than this Job could not be scheduled.
https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/

Which issue(s) this PR fixes:

Closes #1504

Special notes for your reviewer:

Tolerations for delete Agones resources same as for the controller.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: d5c9b492-881e-4fdb-bb40-22ef067a7d89

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1521/head:pr_1521 && git checkout pr_1521
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-3a29023

@@ -47,6 +47,10 @@ spec:
volumeMounts:
- name: script
mountPath: /scripts/
{{- if .Values.agones.controller.tolerations }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this approach. It's the easiest implementation. If people need to have their own custom toleration, we could provide an extra configuration for delete_job toleration, and then default to the controller toleration 👍

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@markmandel markmandel added area/operations Installation, updating, metrics etc kind/cleanup Refactoring code, fixing up documentation, etc lgtm labels May 7, 2020
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 79c5886e-cfb0-4a49-b9b2-1c96597e6ac0

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1521/head:pr_1521 && git checkout pr_1521
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-29ea344

@markmandel markmandel merged commit 6d5174e into googleforgames:master May 7, 2020
@markmandel markmandel added this to the 1.6.0 milestone May 7, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Tolerations for delete Agones resources same as for the controller.

Co-authored-by: Mark Mandel <markmandel@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/operations Installation, updating, metrics etc kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm delete doesn't support tolerations/affinities
4 participants