-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tolerations for delete hook script #1521
Add tolerations for delete hook script #1521
Conversation
Tolerations for delete Agones resources same as for the controller.
Build Succeeded 👏 Build Id: d5c9b492-881e-4fdb-bb40-22ef067a7d89 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
@@ -47,6 +47,10 @@ spec: | |||
volumeMounts: | |||
- name: script | |||
mountPath: /scripts/ | |||
{{- if .Values.agones.controller.tolerations }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this approach. It's the easiest implementation. If people need to have their own custom toleration, we could provide an extra configuration for delete_job toleration, and then default to the controller toleration 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aLekSer, markmandel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Build Succeeded 👏 Build Id: 79c5886e-cfb0-4a49-b9b2-1c96597e6ac0 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Tolerations for delete Agones resources same as for the controller. Co-authored-by: Mark Mandel <markmandel@google.com>
Tolerations for delete Agones resources same as for the controller.
What type of PR is this?
/kind hotfix
What this PR does / Why we need it:
Currently Job for deleting resources created on default node pool. If we add taints to all nodes in default node pool, than this Job could not be scheduled.
https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/
Which issue(s) this PR fixes:
Closes #1504
Special notes for your reviewer: