Small typo in test #1526

aLekSer · 2020-05-07T19:29:39Z

Cleanup the func name.

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

markmandel · 2020-05-07T19:30:55Z

pkg/apis/agones/v1/gameserver_test.go

@@ -1253,7 +1253,7 @@ func TestGameServerPod_ContainerNotFound_ErrReturned(t *testing.T) {

 }

-func TestGameServerPod_WithSidecar_NoErrros(t *testing.T) {
+func TestGameServerPod_WithSidecar_NoErrors(t *testing.T) {


Somehow this slipped in, and I missed it - can we get rid of the _, while we are in here please :D

It's not to Go naming conventions.

By the way underscore is fine for Example functions in tests, probably that's why golint did not show an error:
https://golang.org/pkg/testing/#hdr-Examples
But I was expecting that this name would generate a linter error. More context:
golang/lint#5

agones-bot · 2020-05-07T19:33:34Z

Build Failed 😱

Build Id: dd832000-daef-43d1-b0bf-85cfeceb182e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2020-05-07T19:35:17Z

Been seeing this a bit today: Flakiness.

Step 13/21 : RUN curl -L  ${HELM_URL} > /tmp/helm.tar.gz     && tar -zxvf /tmp/helm.tar.gz -C /tmp     && mv /tmp/linux-amd64/helm /usr/local/bin/helm     && chmod go+rx /usr/local/bin/helm     && rm /tmp/helm.tar.gz && rm -rf /tmp/linux-amd64
 ---> Running in 4416a5fa460b
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

curl: (56) GnuTLS recv error (-54): Error in the pull function.
The command '/bin/sh -c curl -L  ${HELM_URL} > /tmp/helm.tar.gz     && tar -zxvf /tmp/helm.tar.gz -C /tmp     && mv /tmp/linux-amd64/helm /usr/local/bin/helm     && chmod go+rx /usr/local/bin/helm     && rm /tmp/helm.tar.gz && rm -rf /tmp/linux-amd64' returned a non-zero code: 56

agones-bot · 2020-05-08T11:13:10Z

Build Succeeded 👏

Build Id: 6ce8f51a-d6e1-4092-8996-efa97e745a2f

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.6.0-2a1bad6
image: gcr.io/agones-images/agones-sdk:1.6.0-2a1bad6
image: gcr.io/agones-images/agones-ping:1.6.0-2a1bad6
Linux C++ SDK (build): agonessdk-1.6.0-2a1bad6-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.6.0-2a1bad6.zip

A preview of the website (the last 30 builds are retained):

https://2a1bad6-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1526/head:pr_1526 && git checkout pr_1526
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-2a1bad6

agones-bot · 2020-05-08T11:23:34Z

Build Succeeded 👏

Build Id: d1e91e98-85f2-443c-9b89-e1e75737de8f

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.6.0-740a9a0
image: gcr.io/agones-images/agones-sdk:1.6.0-740a9a0
image: gcr.io/agones-images/agones-ping:1.6.0-740a9a0
Linux C++ SDK (build): agonessdk-1.6.0-740a9a0-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.6.0-740a9a0.zip

A preview of the website (the last 30 builds are retained):

https://740a9a0-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1526/head:pr_1526 && git checkout pr_1526
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-740a9a0

markmandel

Yay

google-oss-robot · 2020-05-08T16:45:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot · 2020-05-08T18:04:20Z

New changes are detected. LGTM label has been removed.

agones-bot · 2020-05-08T18:25:09Z

Build Succeeded 👏

Build Id: 286fba28-fe3a-41d9-ab4b-d5b4752d97d6

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.6.0-a9d0eba
image: gcr.io/agones-images/agones-sdk:1.6.0-a9d0eba
image: gcr.io/agones-images/agones-ping:1.6.0-a9d0eba
Linux C++ SDK (build): agonessdk-1.6.0-a9d0eba-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.6.0-a9d0eba.zip

A preview of the website (the last 30 builds are retained):

https://a9d0eba-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1526/head:pr_1526 && git checkout pr_1526
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-a9d0eba

Co-authored-by: Mark Mandel <markmandel@google.com>

google-oss-robot requested review from cyriltovena and pooneh-m May 7, 2020 19:29

google-oss-robot added the size/XS label May 7, 2020

markmandel reviewed May 7, 2020

View reviewed changes

aLekSer force-pushed the fix/typo-in-test branch from 00829ff to 2a1bad6 Compare May 8, 2020 10:54

Small typo in test

740a9a0

aLekSer force-pushed the fix/typo-in-test branch from 2a1bad6 to 740a9a0 Compare May 8, 2020 11:05

markmandel approved these changes May 8, 2020

View reviewed changes

google-oss-robot assigned markmandel May 8, 2020

google-oss-robot added the lgtm label May 8, 2020

google-oss-robot added the approved label May 8, 2020

Merge branch 'master' into fix/typo-in-test

a9d0eba

google-oss-robot removed the lgtm label May 8, 2020

markmandel merged commit 174f49e into googleforgames:master May 8, 2020

markmandel added area/tests Unit tests, e2e tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc labels May 8, 2020

markmandel added this to the 1.6.0 milestone May 19, 2020

ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020

Small typo in test (googleforgames#1526)

67010af

Co-authored-by: Mark Mandel <markmandel@google.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Small typo in test #1526

Small typo in test #1526

aLekSer commented May 7, 2020

markmandel May 7, 2020

aLekSer May 8, 2020 •

edited

Loading

agones-bot commented May 7, 2020

markmandel commented May 7, 2020

agones-bot commented May 8, 2020

agones-bot commented May 8, 2020

markmandel left a comment

google-oss-robot commented May 8, 2020

google-oss-robot commented May 8, 2020

agones-bot commented May 8, 2020

Small typo in test #1526

Small typo in test #1526

Conversation

aLekSer commented May 7, 2020

markmandel May 7, 2020

Choose a reason for hiding this comment

aLekSer May 8, 2020 • edited Loading

Choose a reason for hiding this comment

agones-bot commented May 7, 2020

markmandel commented May 7, 2020

agones-bot commented May 8, 2020

agones-bot commented May 8, 2020

markmandel left a comment

Choose a reason for hiding this comment

google-oss-robot commented May 8, 2020

google-oss-robot commented May 8, 2020

agones-bot commented May 8, 2020

aLekSer May 8, 2020 •

edited

Loading