Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a small typo spotted while reading documentation. #1528

Merged
merged 3 commits into from
May 8, 2020

Conversation

EricFortin
Copy link
Collaborator

@EricFortin EricFortin commented May 8, 2020

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix

What this PR does / Why we need it:
Fixes a typo.

@EricFortin EricFortin added the area/site The website itself - including redirects, styling, search, etc label May 8, 2020
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: d53caf69-9d0a-440f-8fee-93ea39abb4a9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1528/head:pr_1528 && git checkout pr_1528
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-c6f2928

Copy link
Collaborator

@aLekSer aLekSer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, EricFortin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: a9188d02-cc89-45a6-9258-b3befcedc426

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@aLekSer
Copy link
Collaborator

aLekSer commented May 8, 2020

SDK conformance test failed. Something new in Node JS SDK:

Response deserialization failed: Failure: Decoder hit an error
Error: 13 INTERNAL: Failed to parse server response
    at Object.exports.createStatusError (/go/src/agones.dev/agones/sdks/nodejs/node_modules/grpc/src/common.js:91:15)
    at Object.onReceiveStatus (/go/src/agones.dev/agones/sdks/nodejs/node_modules/grpc/src/client_interceptors.js:1209:28)
    at InterceptingListener._callNext (/go/src/agones.dev/agones/sdks/nodejs/node_modules/grpc/src/client_interceptors.js:568:42)
    at InterceptingListener.onReceiveStatus (/go/src/agones.dev/agones/sdks/nodejs/node_modules/grpc/src/client_interceptors.js:618:8)
    at callback (/go/src/agones.dev/agones/sdks/nodejs/node_modules/grpc/src/client_interceptors.js:847:24) {
  code: 13,
  metadata: undefined,
  details: 'Failed to parse server response'
}
{"grpcEndpoint":":9003","message":"Starting SDKServer grpc service...","severity":"info","source":"main","time":"2020-05-08T11:17:09.169509283Z"}

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: b3ad7ed8-7230-40da-a832-3dea6cd37139

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1528/head:pr_1528 && git checkout pr_1528
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-9461ef4

@markmandel markmandel merged commit b37ad74 into googleforgames:master May 8, 2020
@markmandel markmandel added this to the 1.6.0 milestone May 8, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
…es#1528)

Co-authored-by: Alexander Apalikov <alexander.apalikov@globant.com>
Co-authored-by: Mark Mandel <markmandel@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/site The website itself - including redirects, styling, search, etc size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants