E2E Tests for GameServer Player Tracking #1541
Conversation
markmandel
added
kind/feature
test/e2e/gameserver_test.go
Outdated
|
|
||
| reply, err = e2eframework.SendGameServerUDP(gs, "PLAYER_CAPACITY") | ||
| assert.NoError(t, err) | ||
| assert.Equal(t, "20", reply) |
There was a problem hiding this comment.
I think new line is needed here and in all other responses.
| assert.Equal(t, "20", reply) | |
| assert.Equal(t, "20\n", reply) |
|
Overall is great. But it seems that |
|
Build Failed 😱 Build Id: 51afeed4-0431-4e33-8769-ac503959594f To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Updated the udp-simple example to accept various player tracking commands, and also implemented e2e tests to test it working on a singular GameServer instance. Work on googleforgames#1507
markmandel
force-pushed
the
feature/tracking-e2e
branch
from
784b1ec
to
61a4592
Compare
|
Review updates in place, if you are happy with me pushing up the image, I will do so. |
|
Build Failed 😱 Build Id: ad8853b1-85b7-495d-a1d5-d9e151d7c4a6 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
markmandel
force-pushed
the
feature/tracking-e2e
branch
from
61a4592
to
d3b5c75
Compare
|
Build Failed 😱 Build Id: 918af329-00af-4d49-a4e7-b383cb721369 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
markmandel
force-pushed
the
feature/tracking-e2e
branch
from
d3b5c75
to
193bfe6
Compare
|
Build Failed 😱 Build Id: 704ea39d-0170-4012-9588-13895df4f8bf To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aLekSer, markmandel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Image pushed! |
|
Build Succeeded 👏 Build Id: 8ce68ca3-0e69-46b8-a77b-09154d4c6e28 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
Build was successful, please merge when you think it is suitable. |
* E2E Tests for GameServer Player Tracking Updated the udp-simple example to accept various player tracking commands, and also implemented e2e tests to test it working on a singular GameServer instance. Work on googleforgames#1507
* E2E Tests for GameServer Player Tracking Updated the udp-simple example to accept various player tracking commands, and also implemented e2e tests to test it working on a singular GameServer instance. Work on googleforgames#1507
What type of PR is this?
/kind feature
What this PR does / Why we need it:
Updated the udp-simple example to accept various player tracking
commands, and also implemented e2e tests to test it working on a
singular GameServer instance.
Which issue(s) this PR fixes:
Work on #1507
Special notes for your reviewer:
Once people have a chance to review the udp-simple code, I'll make and push the image, so on first run, the build is going to fail.