Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grafana - add namespace to autoscalers dashboard #1615

Merged

Conversation

akremsa
Copy link
Contributor

@akremsa akremsa commented Jun 5, 2020

What type of PR is this?**

/kind bug

What this PR does / Why we need it:
Now we can filter autoscalers dashboards data by namespace.

Which issue(s) this PR fixes:
Closes #1501

Special notes for your reviewer:
image

image

image

Copy link
Collaborator

@aLekSer aLekSer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine to me.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akremsa, aLekSer
To complete the pull request process, please assign markmandel
You can assign the PR to them by writing /assign @markmandel in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aLekSer aLekSer requested a review from cyriltovena June 5, 2020 13:59
@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@markmandel markmandel added area/operations Installation, updating, metrics etc kind/feature New features for Agones lgtm labels Jun 8, 2020
@markmandel markmandel added this to the 1.7.0 milestone Jun 8, 2020
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 7f0f06e5-dd11-4870-8391-f120eb085458

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1615/head:pr_1615 && git checkout pr_1615
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-a6dccd5

@markmandel markmandel merged commit ba5877c into googleforgames:master Jun 8, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
grafana update

Co-authored-by: Mark Mandel <markmandel@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/operations Installation, updating, metrics etc kind/feature New features for Agones lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics: add namespace to distinguish same name fleets
6 participants