Fix 404 in CRD generated documentation. #1621
Conversation
markmandel
added
kind/documentation
markmandel
force-pushed
the
cleanup/crd-gen
branch
2 times, most recently
from
3325758
to
71cb85c
Compare
- Updated gen-crd-api-reference-docs - Added our own config to point to the version of K8s we want. - Manually updated the older CRD ref to point to 1.15, since it doesn't get updated automatically. - Added the ability to the htmltest config to disable external testing, for easier local dev testing. Closes googleforgames#1617
markmandel
force-pushed
the
cleanup/crd-gen
branch
from
71cb85c
to
8f37755
Compare
|
Build Succeeded 👏 Build Id: d67c9681-2dfc-429f-8b2b-1a5d8afec51f The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aLekSer, markmandel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
One potential issue I come up with.Left a comment and will verify it tomorrow. |
| @@ -60,7 +62,7 @@ function sedeasy { | |||
| } | |||
|
|
|||
| # do we have changes in generated API docs compared to previous version | |||
| diff $RESULT $OLD | |||
| diff $RESULT $OLD || true | |||
There was a problem hiding this comment.
This might cause an error. Will it be always true?
I mean the next if on a second run should not update the doc.
There was a problem hiding this comment.
oooh I see this now.
I had to put this in because set -e will exit this process as soon as the diff displays, so sometimes it will never move past this point, especially if ordering in the file changes.
There was a problem hiding this comment.
Got a fix incoming shortly. Good spot.
I introduced a bug in googleforgames#1621 that means that the publish/expiry replacement would never happen. This fixes that issue, while also allowing us to maintain the `set -e` within the bash script.
I introduced a bug in #1621 that means that the publish/expiry replacement would never happen. This fixes that issue, while also allowing us to maintain the `set -e` within the bash script.
- Updated gen-crd-api-reference-docs - Added our own config to point to the version of K8s we want. - Manually updated the older CRD ref to point to 1.15, since it doesn't get updated automatically. - Added the ability to the htmltest config to disable external testing, for easier local dev testing. Closes googleforgames#1617
I introduced a bug in googleforgames#1621 that means that the publish/expiry replacement would never happen. This fixes that issue, while also allowing us to maintain the `set -e` within the bash script.
What type of PR is this?
Fixes blocking 404 in CI
/kind cleanup
What this PR does / Why we need it:
get updated automatically.
for easier local dev testing.
Which issue(s) this PR fixes:
Closes #1617
Special notes for your reviewer:
None.