Added new gen-install-alpha command #1673

akremsa · 2020-07-02T13:26:15Z

What type of PR is this?

/kind feature

What this PR does / Why we need it:
There is a remark in Agones Community Meeting Working Doc about turning on Alpha features via YAML.

I've added a new command which allows us to achieve that.

agones-bot · 2020-07-02T13:43:06Z

Build Failed 😱

Build Id: a9b853d4-9f0b-4e0e-a431-1747591f67f5

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

aLekSer · 2020-07-02T14:00:33Z

Golang SDK conformance test failed:

closing agones SDK
{"message":"shutting down sdk server","severity":"info","source":"main","time":"2020-07-02T13:37:39.670285918Z"}
{"message":"Could not find a request which was expected","request":"ready","sdkName":"go","severity":"error","source":"*sdkserver.LocalSDKServer","time":"2020-07-02T13:37:39.670405518Z"}
{"expected":["ready","allocate","setlabel","setannotation","gameserver","health","shutdown","watch","reserve"],"message":"Testing Failed","received":[],"sdkName":"go","severity":"info","source":"*sdkserver.LocalSDKServer","time":"2020-07-02T13:37:39.670440464Z"}
includes/sdk.mk:145: recipe for target 'run-sdk-conformance-no-build' failed
includes/sdk.mk:152: recipe for target 'run-sdk-conformance-test' failed
make[2]: *** [run-sdk-conformance-no-build] Error 1
make[1]: *** [run-sdk-conformance-test] Error 2
includes/sdk.mk:162: recipe for target 'run-sdk-conformance-test-go' failed

agones-bot · 2020-07-02T14:02:02Z

Build Succeeded 👏

Build Id: 76d93fcb-1792-4d9e-8508-268136ac7a10

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.7.0-44417e1
image: gcr.io/agones-images/agones-sdk:1.7.0-44417e1
image: gcr.io/agones-images/agones-ping:1.7.0-44417e1
Linux C++ SDK (build): agonessdk-1.7.0-44417e1-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.7.0-44417e1.zip

A preview of the website (the last 30 builds are retained):

https://44417e1-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1673/head:pr_1673 && git checkout pr_1673
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-44417e1

markmandel · 2020-07-06T17:52:57Z

Question:
Rather than generating each permutation of index.yaml that could exist - should we instead document how you can use helm to generate your own index.yaml if one so desires?

WDYT?

akremsa · 2020-07-07T11:33:27Z

We discussed this option with @aLekSer as well but decided to add another one file, just to start this discussion at least. Alexander, what is your opinion?

aLekSer · 2020-07-07T18:27:59Z

Well, an idea behind was to add a pre-generated yaml file with all Alpha features enabled for those guys who don't like dealing with helm.
I like your idea to gave users clear instructions on how to use helm template agones-manual and this could be taken even further by saying on agones.dev:

These parts of install.yaml could be edited as long as they conform with the following table https://agones.dev/site/docs/installation/install-agones/helm/#configuration:
        - name: MIN_PORT
          value: "7000"
        - name: FEATURE_GATES
          value: ""

markmandel · 2020-07-09T19:03:32Z

Yeah, doing both helm template instructions, and also where to update Feature flags is a good idea.

Although that does mean that if we change places that feature flags occur in the index.yaml we need to remember to update them - so maybe we don't want to do that, and just do the helm template?

aLekSer · 2020-07-13T16:52:36Z

Those 3 commands could do the job, but I am not sure what metadata is needed:

 helm3 pull --untar https://agones.dev/chart/stable/agones-1.7.0-rc.tgz 
cd agones
 helm3 template ./templates  --namespace agones-system --set agones.controller.generateTLS=false 
Error: validation: chart.metadata is required

Using this as a starting point https://www.padok.fr/en/blog/helm-3-commands

akremsa · 2020-07-13T23:08:59Z

@aLekSer, thanks for the tip.
I decided to update this PR rather than creating a new one in order to keep a discussion history here.
@markmandel, please check.

akremsa · 2020-07-13T23:17:15Z

Result:

agones-bot · 2020-07-13T23:27:05Z

Build Failed 😱

Build Id: c51839df-4259-4704-89e8-284e0354567a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-07-13T23:27:59Z

Build Succeeded 👏

Build Id: 836647f4-ce6c-4695-b085-79e896f8fd3d

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.8.0-9dad1cb
image: gcr.io/agones-images/agones-sdk:1.8.0-9dad1cb
image: gcr.io/agones-images/agones-ping:1.8.0-9dad1cb
Linux C++ SDK (build): agonessdk-1.8.0-9dad1cb-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.8.0-9dad1cb.zip

A preview of the website (the last 30 builds are retained):

https://9dad1cb-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1673/head:pr_1673 && git checkout pr_1673
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-9dad1cb

site/content/en/docs/Installation/Install Agones/yaml.md

aLekSer

I think this version is quite readable and easy to use by the users. Please update following the small comments.

akremsa · 2020-07-14T13:09:30Z

@aLekSer thanks for the notes, PR is updated.

agones-bot · 2020-07-14T13:21:30Z

Build Failed 😱

Build Id: a72e1e3d-c3a3-418d-a3f6-d71ed4d05628

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2020-07-14T20:32:46Z

Looks like you'll need gen the api docs 👍

includes/website.mk:98: recipe for target 'test-gen-api-docs' failed

site/content/en/docs/Installation/Install Agones/yaml.md

review notes fix

agones-bot · 2020-07-14T22:48:47Z

Build Succeeded 👏

Build Id: ad374dca-be21-494e-a383-76d2ce76b725

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.8.0-e6cd76f
image: gcr.io/agones-images/agones-sdk:1.8.0-e6cd76f
image: gcr.io/agones-images/agones-ping:1.8.0-e6cd76f
Linux C++ SDK (build): agonessdk-1.8.0-e6cd76f-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.8.0-e6cd76f.zip

A preview of the website (the last 30 builds are retained):

https://e6cd76f-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1673/head:pr_1673 && git checkout pr_1673
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-e6cd76f

markmandel

LGTM!

google-oss-robot · 2020-07-14T23:17:32Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akremsa, aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* Described how to add parameters to yaml using helm * added crd api reference

google-oss-robot requested review from EricFortin and pooneh-m July 2, 2020 13:26

googlebot added the cla: yes label Jul 2, 2020

google-oss-robot added the size/XXL label Jul 2, 2020

akremsa force-pushed the install-alpha-yaml branch from 6fe1873 to 44417e1 Compare July 2, 2020 13:40

markmandel added the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Jul 6, 2020

markmandel removed the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Jul 7, 2020

akremsa force-pushed the install-alpha-yaml branch from 44417e1 to 9dad1cb Compare July 13, 2020 23:07

google-oss-robot added size/S and removed size/XXL labels Jul 13, 2020

akremsa force-pushed the install-alpha-yaml branch from 9dad1cb to 0d469e6 Compare July 13, 2020 23:15

aLekSer reviewed Jul 14, 2020

View reviewed changes

site/content/en/docs/Installation/Install Agones/yaml.md Outdated Show resolved Hide resolved

aLekSer reviewed Jul 14, 2020

View reviewed changes

site/content/en/docs/Installation/Install Agones/yaml.md Outdated Show resolved Hide resolved

aLekSer approved these changes Jul 14, 2020

View reviewed changes

google-oss-robot assigned aLekSer Jul 14, 2020

google-oss-robot added the lgtm label Jul 14, 2020

akremsa force-pushed the install-alpha-yaml branch from 0d469e6 to c018434 Compare July 14, 2020 13:09

google-oss-robot removed the lgtm label Jul 14, 2020

markmandel reviewed Jul 14, 2020

View reviewed changes

site/content/en/docs/Installation/Install Agones/yaml.md Outdated Show resolved Hide resolved

markmandel reviewed Jul 14, 2020

View reviewed changes

site/content/en/docs/Installation/Install Agones/yaml.md Outdated Show resolved Hide resolved

alexey-kremsa-globant added 2 commits July 15, 2020 01:17

Described how to add parameters to yaml using helm

fbd37be

review notes fix

added crd api reference

e6cd76f

akremsa force-pushed the install-alpha-yaml branch from c018434 to e6cd76f Compare July 14, 2020 22:27

google-oss-robot added size/XXL and removed size/S labels Jul 14, 2020

markmandel approved these changes Jul 14, 2020

View reviewed changes

google-oss-robot assigned markmandel Jul 14, 2020

google-oss-robot added the lgtm label Jul 14, 2020

google-oss-robot added the approved label Jul 14, 2020

markmandel added kind/documentation Documentation for Agones kind/feature New features for Agones labels Jul 14, 2020

markmandel added this to the 1.8.0 milestone Jul 14, 2020

markmandel merged commit c97864f into googleforgames:master Jul 14, 2020

ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020

Added new gen-install-alpha command (googleforgames#1673)

8bc2e27

* Described how to add parameters to yaml using helm * added crd api reference

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added new gen-install-alpha command #1673

Added new gen-install-alpha command #1673

akremsa commented Jul 2, 2020

agones-bot commented Jul 2, 2020

aLekSer commented Jul 2, 2020

agones-bot commented Jul 2, 2020

markmandel commented Jul 6, 2020

akremsa commented Jul 7, 2020

aLekSer commented Jul 7, 2020 •

edited

Loading

markmandel commented Jul 9, 2020

aLekSer commented Jul 13, 2020

akremsa commented Jul 13, 2020

akremsa commented Jul 13, 2020

agones-bot commented Jul 13, 2020

agones-bot commented Jul 13, 2020

aLekSer left a comment

akremsa commented Jul 14, 2020 •

edited

Loading

agones-bot commented Jul 14, 2020

markmandel commented Jul 14, 2020

agones-bot commented Jul 14, 2020

markmandel left a comment

google-oss-robot commented Jul 14, 2020

Added new gen-install-alpha command #1673

Added new gen-install-alpha command #1673

Conversation

akremsa commented Jul 2, 2020

agones-bot commented Jul 2, 2020

aLekSer commented Jul 2, 2020

agones-bot commented Jul 2, 2020

markmandel commented Jul 6, 2020

akremsa commented Jul 7, 2020

aLekSer commented Jul 7, 2020 • edited Loading

markmandel commented Jul 9, 2020

aLekSer commented Jul 13, 2020

akremsa commented Jul 13, 2020

akremsa commented Jul 13, 2020

agones-bot commented Jul 13, 2020

agones-bot commented Jul 13, 2020

aLekSer left a comment

Choose a reason for hiding this comment

akremsa commented Jul 14, 2020 • edited Loading

agones-bot commented Jul 14, 2020

markmandel commented Jul 14, 2020

agones-bot commented Jul 14, 2020

markmandel left a comment

Choose a reason for hiding this comment

google-oss-robot commented Jul 14, 2020

aLekSer commented Jul 7, 2020 •

edited

Loading

akremsa commented Jul 14, 2020 •

edited

Loading