Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Website minor fix link and formatting #1708

Merged
merged 3 commits into from
Jul 23, 2020
Merged

Website minor fix link and formatting #1708

merged 3 commits into from
Jul 23, 2020

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Jul 21, 2020

There was a broken link and few missing dots.

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 074c73ff-12c5-4e26-a502-631c26aba219

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey
Copy link
Member

The html test failed on this PR too... I wonder if it's just plain broken instead of flaky.

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: afecaba2-b469-40a8-9633-fc5855313f10

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1708/head:pr_1708 && git checkout pr_1708
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-fe2db94

@aLekSer aLekSer merged commit 833277e into googleforgames:master Jul 23, 2020
@aLekSer aLekSer deleted the website/fix-link branch July 23, 2020 13:20
@markmandel markmandel added this to the 1.8.0 milestone Aug 11, 2020
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones labels Aug 11, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@aLekSer @ilkercelikyilmaz
Website minor fix link and formatting (googleforgames#1708)
1043d8e 
* Fix link on a website

On FAQ page.

* Adding some missing dots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

@markmandel markmandel Awaiting requested review from markmandel

Assignees

@roberthbailey roberthbailey

Labels
approved cla: yes kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones size/S
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
6 participants
@aLekSer @agones-bot @google-oss-robot @roberthbailey @markmandel @googlebot