From c6f03982cfa11667c308623627b5e8ffa7874678 Mon Sep 17 00:00:00 2001 From: Alexander Apalikov Date: Tue, 21 Jul 2020 21:47:04 +0300 Subject: [PATCH 1/2] Fix link on a website On FAQ page. --- site/content/en/docs/FAQ/_index.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/site/content/en/docs/FAQ/_index.md b/site/content/en/docs/FAQ/_index.md index 44d46fda52..530350bed1 100644 --- a/site/content/en/docs/FAQ/_index.md +++ b/site/content/en/docs/FAQ/_index.md @@ -156,7 +156,7 @@ We routinely see users running container images that are multiple GB in size. The only downside to larger images, is that they can take longer to first load on a Kubernetes node, but that can be managed by your [Fleet]({{< ref "/docs/Reference/fleet.md" >}}) and -[Fleet Autoscaling]({{< ref "/docs/Reference/fleetautoscaler.md" >}} +[Fleet Autoscaling]({{< ref "/docs/Reference/fleetautoscaler.md" >}}) configuration to ensure this load time is taken into account on a new Node's container initial load. ### How quickly can Agones spin up new GameServer instances? From 0478104122af1ee22023fb57748bd14fd9cf470b Mon Sep 17 00:00:00 2001 From: Alexander Apalikov Date: Tue, 21 Jul 2020 22:05:46 +0300 Subject: [PATCH 2/2] Adding some missing dots. --- build/README.md | 6 +++--- site/content/en/docs/Guides/Client SDKs/_index.md | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/build/README.md b/build/README.md index 08cdcf5b71..05ba5c866a 100644 --- a/build/README.md +++ b/build/README.md @@ -371,7 +371,7 @@ Have a look in the [examples](../examples) folder to see examples of running Gam ## Make Variable Reference ### VERSION -The version of this build. Version defaults to the short hash of the latest commit +The version of this build. Version defaults to the short hash of the latest commit. ### REGISTRY The registry that is being used to store docker images. Defaults to gcr.io/agones-images - the release + CI registry. @@ -380,7 +380,7 @@ The registry that is being used to store docker images. Defaults to gcr.io/agone The Kubernetes config file used to access the cluster. Defaults to `~/.kube/config` - the file used by default by kubectl. ### CLUSTER_NAME -The (gcloud) test cluster that is being worked against. Defaults to `test-cluster` +The (gcloud) test cluster that is being worked against. Defaults to `test-cluster`. ### GCP_PROJECT Your GCP project for deploying GKE cluster. Defaults to gcloud default project settings. @@ -405,7 +405,7 @@ All targets will create the build image if it is not present. ### Development Targets -Targets for developing with the build image +Targets for developing with the build image. #### `make build` Build all the images required for Agones, as well as the SDKs diff --git a/site/content/en/docs/Guides/Client SDKs/_index.md b/site/content/en/docs/Guides/Client SDKs/_index.md index 0ac271013e..e396c46347 100644 --- a/site/content/en/docs/Guides/Client SDKs/_index.md +++ b/site/content/en/docs/Guides/Client SDKs/_index.md @@ -171,7 +171,7 @@ You can use `SDKWatchSendOnExecute` feature passed as a [feature gate]({{< ref " #### SetLabel(key, value) This will set a [Label](https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/) value on the backing `GameServer` -record that is stored in Kubernetes. To maintain isolation, the `key` value is automatically prefixed with "agones.dev/sdk-" +record that is stored in Kubernetes. To maintain isolation, the `key` value is automatically prefixed with "agones.dev/sdk-". {{< alert title="Warning" color="warning">}} There are limits on the characters that be used for label keys and values. Details are [here](https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#syntax-and-character-set). @@ -182,7 +182,7 @@ This can be useful if you want information from your running game server process #### SetAnnotation(key, value) This will set a [Annotation](https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/) value on the backing -`Gameserver` record that is stored in Kubernetes. To maintain isolation, the `key` value is automatically prefixed with "agones.dev/sdk-" +`GameServer` record that is stored in Kubernetes. To maintain isolation, the `key` value is automatically prefixed with "agones.dev/sdk-". This can be useful if you want information from your running game server process to be observable through the Kubernetes API.